From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756063AbcIFNjk (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Sep 2016 09:39:40 -0400
Received: from mout.kundenserver.de ([212.227.126.131]:51840 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751258AbcIFNjh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Sep 2016 09:39:37 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: David Howells <dhowells@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rxrpc: remove duplicate 'error' variable
Date: Tue, 06 Sep 2016 15:39:59 +0200
Message-ID: <8706362.vunRxcsNaf@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <32472.1473168842@warthog.procyon.org.uk>
References: <20160906132614.2117695-1-arnd@arndb.de> <32472.1473168842@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:7SE5tn1IrzoOtlSBjrFL2H3WPTMjCgPfUmdGysNA5oHG8N6MC6n
 CBSYqWQQy5q6OMxGusm5Ca6LiIP/O3iyRrSeT0QbLW3DpoxEzVB5l4U7V9TOll5ILXK5FlI
 c2OEHh48t0jLgFl0M7+AchU4Cmasirhi8txBEWVwvgJgFU6M8rHklfgmP6UvAo9f5Ai/tWU
 tEFMCrD/OZIWOy59mbfSA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:+R97YuUzgx0=:rJ+kZqTcrqZhqMCDFDhheh
 EyNcWtfzHH0AbwDUeUfoR37FeVC1ULRvOze9XY3bQrEFjQw7vNsrH5hcYDzjG5yKam6ufb3vr
 IylDmR7/OWiKVY+Fu+mRrEomgw6EYKbuV+RDjec4bttNaLl35TuvXGwO/ErdywFSpzSKXPMOC
 zWx+GbNWxn8xbqBliUAUGvTpH1osVUfLfahJLIY8ILz+jcJIUbbK7X6gtGvPtXCBT/kg499kI
 VCWHzXsfjBcgdPeqGHp2Nw2q/CFpRN+utMetOZUnIDHC79bb0/XmwJdv1OcZS/7Et9yctRzQ2
 H5UyH+Mveyto7FKJn/a/MjUHWom81V8FvrMVt6bVZ9yj09nYp8TtlDcHhyoNpAyIgGBPrW5WB
 2479rmwT3fo4/y6HR9/LRvpclofFJmwgCQ2Tf2ZAErT42I7jOmlVZ4w7konYhZwGyOedYlDGl
 geBIL5B+k9+onwRepifHx1P404Oh3UEalQ5Bhz2gwgAG7nAmgOc4sXPDV0wpo+pdIGeiU7t1q
 aROE05LMhbXSY5EkOzumcWeFjlxMbZ1fp15JDCFLiIvC+dj7jyX/AjoXgGGZBUrxANOMf/goV
 jv07N498nIMriMaUZM5WLusbAr4rv09z3ccg83fnX8Do2UaTaLI1FprJTTWCaRmZlR5PaK0P2
 0AcdpXxrAdCgs2n/w1djXYx3LgXnV8h3XlW/sWb+lEuAMFm3PSEdKrZq6k8op6P8EsxV38/Mv
 jsE6VNiM2xCNvycm
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, September 6, 2016 2:34:02 PM CEST David Howells wrote:
> Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > The rxrpc_process_call function has debug code to print a failure code,
> > but instead of printing the code from the rxrpc_call structure, it
> > prints an uninitialized variable:
> > 
> > net/rxrpc/call_event.c: In function 'rxrpc_process_call':
> > net/rxrpc/call_event.c:879:58: error: 'error' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> > 
> > This removes the extraneous variable and prints the correct
> > code instead.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: f5c17aaeb2ae ("rxrpc: Calls should only have one terminal state")
> 
> I've already posted a fix and it's waiting on DaveM.
> 
> https://patchwork.ozlabs.org/patch/665550/
> 
> http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/commit/?h=rxrpc-rewrite&id=00b5407e427ac2588a2496b92035a94602b3cd1b

Ok, good. At least I'm glad my patch is correct this time (being identical
to yours).

	Arnd