Re: [RFC] Sound support for Huawei line of AMD laptops using ACP and ES8336 codec

From: Marian Postevca <posteuca@mutex.one>
To: "Limonciello, Mario" <mario.limonciello@amd.com>,
	"Reddy, V sujith kumar" <vsujithkumar.reddy@amd.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
	syed sabakareem <Syed.SabaKareem@amd.com>
Subject: Re: [RFC] Sound support for Huawei line of AMD laptops using ACP and ES8336 codec
Date: Tue, 10 Jan 2023 14:27:54 +0200	[thread overview]
Message-ID: <871qo2bmlx.fsf@mutex.one> (raw)
In-Reply-To: <8349cf5f-1e26-f605-4404-978dbef9cee3@amd.com>

Hello V sujith kumar, Mario,

Thanks for the replies to my email.

"Limonciello, Mario" <mario.limonciello@amd.com> writes:

> On 1/7/2023 00:58, Reddy, V sujith kumar wrote:
>> 
>> Could you please send  the error, we will check and let you know what is 
>> missing.
>
> Just a guess here without seeing the error.  Is this perhaps because the 
> SOF F/W binary that was loaded was not signed with signature trusted by 
> the platform and the platform required validation?
>
> SOF on AMD was first introduced for Chromebooks which don't use the same 
> authority for firmware binary verification that general purpose UEFI 
> notebooks would use.

So I compiled the latest sof firmware from main branch commit
90c14e56cb, and now it seems I get additional errors that I didn't get a
few months ago when I last tried:
[   38.251393] snd_sof_amd_renoir 0000:03:00.5: enabling device (0000 -> 0002)
[   38.252944] snd_sof_amd_renoir 0000:03:00.5: unknown sof_ext_man header type 3 size 0x30
[   38.252955] snd_sof_amd_renoir 0000:03:00.5: Firmware info: version 2:0:0-90c14
[   38.252957] snd_sof_amd_renoir 0000:03:00.5: Firmware: ABI 3:26:0 Kernel ABI 3:23:0
[   41.345068] snd_sof_amd_renoir 0000:03:00.5: ------------[ DSP dump start ]------------
[   41.345080] snd_sof_amd_renoir 0000:03:00.5: Firmware boot failure due to timeout
[   41.345085] snd_sof_amd_renoir 0000:03:00.5: fw_state: SOF_FW_BOOT_IN_PROGRESS (2)
[   41.345137] snd_sof_amd_renoir 0000:03:00.5: invalid header size 0x7f841000. FW oops is bogus
[   41.345142] snd_sof_amd_renoir 0000:03:00.5: unexpected fault 0x7f840000 trace 0x7f840000
[   41.345146] snd_sof_amd_renoir 0000:03:00.5: ------------[ DSP dump end ]------------
[   41.345150] snd_sof_amd_renoir 0000:03:00.5: error: failed to boot DSP firmware -5
[   41.345266] snd_sof_amd_renoir 0000:03:00.5: error: sof_probe_work failed err: -5

The kernel I'm running on is based on the asoc tree from Mark Brown:
git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

commit f8778e910cab179f5835386a0a70847921a8fbec (sound/for-next)
Merge: cdfa92eb90f5 b11845893678
Author: Mark Brown <broonie@kernel.org>
Date:   Fri Jan 6 17:04:36 2023 +0000

    Merge remote-tracking branch 'asoc/for-6.3' into asoc-next

Let me know what other information you need in order to debug this.