From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 82D2BC38145
	for <linux-kernel@archiver.kernel.org>; Thu,  8 Sep 2022 06:23:30 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229943AbiIHGX2 (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 8 Sep 2022 02:23:28 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41152 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230283AbiIHGXW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Sep 2022 02:23:22 -0400
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCB1ACCD71
        for <linux-kernel@vger.kernel.org>; Wed,  7 Sep 2022 23:23:20 -0700 (PDT)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
        (No client certificate requested)
        by smtp-out2.suse.de (Postfix) with ESMTPS id 70DA5200E0;
        Thu,  8 Sep 2022 06:23:19 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1662618199; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=rRXcrIe686naS5cahSfQ0KvTuDfv4mJDsYj6qOKddxA=;
        b=nXDc0mjzZn8MOUh/v4DM3H+lhtZ7MjjeJs5y/M1TjDTm+xADe/Chxpo0cFUB+iOhuSApSP
        teqt3zeZj3iHkMqHKSMfCkVFPPpMlRp/zLS8UJUTuzW4JHDIAGhyPhUTkV/GT0y9Dh2O9q
        80xWvoTpPIxscMbZTrN5AH+5KPuPHwA=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1662618199;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=rRXcrIe686naS5cahSfQ0KvTuDfv4mJDsYj6qOKddxA=;
        b=zl0zgd9cJnLofzuSpIR16z+v9YmloR33LJJmkaSEVjnA1XiT3dYJUUQHXSohPNro9kLWhh
        3atau9xIogZoNbBg==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
        (No client certificate requested)
        by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3E1861322C;
        Thu,  8 Sep 2022 06:23:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
        by imap2.suse-dmz.suse.de with ESMTPSA
        id KsFkDleKGWNBNQAAMHmgww
        (envelope-from <tiwai@suse.de>); Thu, 08 Sep 2022 06:23:19 +0000
Date:   Thu, 08 Sep 2022 08:23:18 +0200
Message-ID: <871qsme65l.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     Takashi Iwai <tiwai@suse.de>, Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <jroedel@suse.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Eric Auger <eric.auger@redhat.com>,
        regressions@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION 5.19.x] AMD HD-audio devices missing on 5.19
In-Reply-To: <YxihMchpLRPAqNWx@nvidia.com>
References: <874jy4cqok.wl-tiwai@suse.de>
        <20220823010021.GA5967@nvidia.com>
        <87h723sdde.wl-tiwai@suse.de>
        <87ilmjqj1f.wl-tiwai@suse.de>
        <20220823202824.GA4516@nvidia.com>
        <87bkrrl3eo.wl-tiwai@suse.de>
        <YxihMchpLRPAqNWx@nvidia.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 07 Sep 2022 15:48:33 +0200,
Jason Gunthorpe wrote:
> 
> On Wed, Sep 07, 2022 at 03:28:31PM +0200, Takashi Iwai wrote:
> > >  /**
> > >   * iommu_device_use_default_domain() - Device driver wants to handle device
> > >   *                                     DMA through the kernel DMA API.
> > > @@ -3094,8 +3112,7 @@ int iommu_device_use_default_domain(struct device *dev)
> > >  
> > >  	mutex_lock(&group->mutex);
> > >  	if (group->owner_cnt) {
> > > -		if (group->domain != group->default_domain ||
> > > -		    group->owner) {
> > > +		if (group->owner || iommu_is_default_domain(group)) {
> > 
> > Isn't this rather 
> > 		if (group->owner || !iommu_is_default_domain(group)) {
> > ?
> > 
> > I'll rebuild the kernel with this change and ask reporters again.
> 
> Oh yes, good eyes, that probably crashes on boot too

Indeed the corrected patch seems working; it boots and the HD-audio
device appears again.

Can we go forward with this?


thanks,

Takashi