From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 364F9C433F5 for ; Tue, 17 May 2022 10:17:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235576AbiEQKRp (ORCPT ); Tue, 17 May 2022 06:17:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344929AbiEQKRP (ORCPT ); Tue, 17 May 2022 06:17:15 -0400 Received: from mail.toke.dk (mail.toke.dk [45.145.95.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A826D4D276; Tue, 17 May 2022 03:14:35 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1652782473; bh=YrEZUatGpcW6tx9M6a5LX6XMkYrfUhXhCp7HQ5atufo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=TrXosL0UZZkkt6fgbk91csygw41EyeGqBPO2f0cbhR2uUJgC9DINRS7ou8/BH23sE XHIMAtA8Ni+ZFeQdICfmXbsMbNC/u4lT7JEFQ5Fdk7FjbXNdxYJrtbh9E4Unyk/fyk +KwfvycX5F184GS4qDFYApGLW3dmgQq8SRv3whpEjIc7y1ZuFkGCeM9exzmly6LzY0 zy4ZyS1WopTWdsRyTgkmy3HomagWPwB3QycXz+L/DG9KKVqfH8nqd2ytCPMhvAiZDy Ehy6rYKsFo67oBWSg5SbKYrtUATZ6VbcHOapx2ZSrOih0JbyyoiTm1SgwlTtkkodtd 5RbsJIH+0gn6w== To: Pavel Skripkin , kvalo@kernel.org, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Skripkin , Jeff Johnson Subject: Re: [PATCH v4 2/2] ath9k: htc: clean up statistics macros In-Reply-To: <4456bd112b9d35f1cb659ed2ecc1c7107ebf2b91.1652553719.git.paskripkin@gmail.com> References: <4456bd112b9d35f1cb659ed2ecc1c7107ebf2b91.1652553719.git.paskripkin@gmail.com> Date: Tue, 17 May 2022 12:14:33 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <871qwscvp2.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pavel Skripkin writes: > I've changed *STAT_* macros a bit in previous patch and I seems like > they become really unreadable. Align these macros definitions to make > code cleaner and fix folllowing checkpatch warning > > ERROR: Macros with complex values should be enclosed in parentheses > > Also, statistics macros now accept an hif_dev as argument, since > macros that depend on having a local variable with a magic name > don't abide by the coding style. > > No functional change > > Suggested-by: Jeff Johnson > Signed-off-by: Pavel Skripkin > --- This patch doesn't apply; please rebase on top of the ath-next branch in Kalle's 'ath' tree... -Toke