From: "Bjørn Mork" <bjorn@mork.no>
To: Oliver Neukum <oneukum@suse.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Johan Hovold <johan@kernel.org>,
Oleksij Rempel <linux@rempel-privat.de>,
Dongliang Mu <dzm91@hust.edu.cn>,
Oliver Neukum <oliver@neukum.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Dongliang Mu <mudongliangabcd@gmail.com>,
syzbot+eabbf2aaa999cc507108@syzkaller.appspotmail.com,
USB <linux-usb@vger.kernel.org>, netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] driver: usb: nullify dangling pointer in cdc_ncm_free
Date: Tue, 19 Apr 2022 22:25:54 +0200 [thread overview]
Message-ID: <871qxsrfal.fsf@miraculix.mork.no> (raw)
In-Reply-To: <d851497f-7960-b606-2f87-eb9bff89c8ac@suse.com> (Oliver Neukum's message of "Tue, 19 Apr 2022 13:47:40 +0200")
Oliver Neukum <oneukum@suse.com> writes:
> It seems to me that fundamentally the order of actions to handle
> a hotunplug must mirror the order in a hotplug. We can add more hooks
> if that turns out to be necessary for some drivers, but the basic
> reverse mirrored order must be supported and I very much favor
> restoring it as default.
FWIW, I agree 100% with this. Please go ahead with the revert of commit
2c9d6c2b871d ("usbnet: run unbind() before unregister_netdev()").
AFAICS, your proposed new hook should solve the original problem just
fine.
Bjørn
next prev parent reply other threads:[~2022-04-19 20:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 12:09 [PATCH] driver: usb: nullify dangling pointer in cdc_ncm_free Dongliang Mu
2022-04-11 12:14 ` Johan Hovold
2022-04-14 13:58 ` Dongliang Mu
2022-04-14 14:03 ` Dongliang Mu
2022-04-14 15:01 ` Andy Shevchenko
2022-04-15 7:19 ` Oleksij Rempel
2022-04-19 11:47 ` Oliver Neukum
2022-04-19 20:25 ` Bjørn Mork [this message]
2022-04-20 6:56 ` Johan Hovold
2022-04-20 9:45 ` Oliver Neukum
2022-04-20 10:06 ` Johan Hovold
2022-04-21 11:18 ` Oliver Neukum
2022-04-11 14:51 ` Andy Shevchenko
2022-04-14 13:59 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qxsrfal.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=dzm91@hust.edu.cn \
--cc=johan@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=mudongliangabcd@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=syzbot+eabbf2aaa999cc507108@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).