From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA421C47255 for ; Mon, 11 May 2020 11:54:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDAC42075E for ; Mon, 11 May 2020 11:54:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729820AbgEKLy5 (ORCPT ); Mon, 11 May 2020 07:54:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726068AbgEKLy4 (ORCPT ); Mon, 11 May 2020 07:54:56 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9866FC061A0C for ; Mon, 11 May 2020 04:54:56 -0700 (PDT) Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jY70w-0004ZX-Cc; Mon, 11 May 2020 13:54:30 +0200 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id AB288FFBF8; Mon, 11 May 2020 13:54:29 +0200 (CEST) From: Thomas Gleixner To: Alexandre Chartre , LKML Cc: x86@kernel.org, "Paul E. McKenney" , Andy Lutomirski , Frederic Weisbecker , Paolo Bonzini , Sean Christopherson , Masami Hiramatsu , Petr Mladek , Steven Rostedt , Joel Fernandes , Boris Ostrovsky , Juergen Gross , Brian Gerst , Mathieu Desnoyers , Josh Poimboeuf , Will Deacon Subject: Re: [patch V4 part 5 02/31] x86/entry: Provide helpers for execute on irqstack In-Reply-To: <7477e59e-50d9-3446-dce7-3aa07e74cf5f@oracle.com> References: <20200505135341.730586321@linutronix.de> <20200505135828.316937774@linutronix.de> <7477e59e-50d9-3446-dce7-3aa07e74cf5f@oracle.com> Date: Mon, 11 May 2020 13:54:29 +0200 Message-ID: <871rnq7klm.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexandre Chartre writes: > On 5/5/20 3:53 PM, Thomas Gleixner wrote: >> + __this_cpu_add(irq_count, 1); \ >> + asm volatile( \ >> + "pushq %%rbp \n" \ >> + "movq %%rsp, %%rbp \n" \ >> + "movq %%rsp, (%[ts]) \n" \ >> + "movq %[ts], %%rsp \n" \ >> + "1: \n" \ >> + " .pushsection .discard.instr_begin \n" \ >> + " .long 1b - . \n" \ >> + " .popsection \n" \ >> + "call " __ASM_FORM(func) " \n" \ >> + "2: \n" \ >> + " .pushsection .discard.instr_end \n" \ >> + " .long 2b - . \n" \ >> + " .popsection \n" \ >> + "popq %%rsp \n" \ >> + "leaveq \n" \ >> + : \ >> + : [ts] "r" (tos) \ >> + : "memory" \ >> + ); \ >> + __this_cpu_sub(irq_count, 1); \ >> +} > > The pushsection/popsection discard.instr_begin/end sequences are used several > times in asm() statement at different places, so I wonder if it might be worth > having a macro. As discussed elsewhere this is going to move to ASM partially and the various variants are not longer necessary. Thanks, tglx