From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE9B4C2D0C6 for ; Thu, 12 Dec 2019 02:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE67F214D8 for ; Thu, 12 Dec 2019 02:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727749AbfLLCJY (ORCPT ); Wed, 11 Dec 2019 21:09:24 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:40128 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727665AbfLLCJY (ORCPT ); Wed, 11 Dec 2019 21:09:24 -0500 Date: 12 Dec 2019 11:09:22 +0900 X-IronPort-AV: E=Sophos;i="5.69,303,1571670000"; d="scan'208";a="33953614" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 12 Dec 2019 11:09:22 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 896DF400C4CB; Thu, 12 Dec 2019 11:09:22 +0900 (JST) Message-ID: <871rtae1m5.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: CONFIG_COMMON_CLK vs CONFIG_HAVE_CLK User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi I noticed that there are some CONFIG_HAVE_CLK vs CONFIG_COMMON_CLK mismatch. Because of it, I got compile error at clk_set_min_rate() on SH. SH will have HAVE_CLK, but doesn't have COMMON_CLK. > ARCH=sh make allyesconfig > make ... drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target': tegra30-devfreq.c:(.text+0x368): undefined reference to `clk_set_min_rate' clk_set_min_rate() is under HAVE_CLK at clk.h --- clk.h --- => #ifdef CONFIG_HAVE_CLK ... int clk_set_min_rate(struct clk *clk, unsigned long rate); ... #else /* !CONFIG_HAVE_CLK */ static inline int clk_set_min_rate(struct clk *clk, unsigned long rate) ... ------------- It is implemented at clk.c. But it will be compiled via COMMON_CLK --- Makefile --- ... => obj-$(CONFIG_COMMON_CLK) += clk.o ... ---------------- Thank you for your help !! Best regards --- Kuninori Morimoto