From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0217C3A59C for ; Fri, 16 Aug 2019 16:16:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A0C32086C for ; Fri, 16 Aug 2019 16:16:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727431AbfHPQQV (ORCPT ); Fri, 16 Aug 2019 12:16:21 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:42697 "EHLO mail-wr1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbfHPQQU (ORCPT ); Fri, 16 Aug 2019 12:16:20 -0400 Received: by mail-wr1-f47.google.com with SMTP id b16so2051457wrq.9 for ; Fri, 16 Aug 2019 09:16:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=aXOWm885zlSQjaOTNsiB6ixyEYYi9R71KVEE87CvUak=; b=h4DtxmSlUw9TqH7zxEdjC2JI/DRm8fztqIoAjXImuS+eBIecleeCG4Juf3kxuhV9NB jTRjtD6Sw1nTopBNt6iLSCtyHQzKnJhz8wxJHbQ1B5bdg58/o8ptWEG0IwtfeJ2iD8Ir FMli7+OdEVU2qDOn9vPkWC1GH/CWg/PsJ0yf5SqjkZhZ+H/CNA2o2MpGh+OGqtGoQoy0 +VgLJtZP0bqVcnHpZhEY7EzIrpTTvqjidyD6UD8iUqKVrl9PV2gMWOLxyyfaqZUyxE+f +EeBTU7T8B3rKnHPpV59DQFymgViuLN5EMWGuzPHSFRmPk0alI3fQwxasL3jOl7NrmWc rF8w== X-Gm-Message-State: APjAAAWIHImWXLgUEWgWNVpOfnimUOmulujWWxO+cdU7lCfIFAg8rSNf IVZqa9xsppXYbmkNn1yama9EIg== X-Google-Smtp-Source: APXvYqy6B4y9yrIXuG+5Spcygji8YfnMrNZIuzappqSMix4ReJs2eJshqSyIxnLvZ0v0kauGmsdKjg== X-Received: by 2002:a5d:6b84:: with SMTP id n4mr12261415wrx.118.1565972178874; Fri, 16 Aug 2019 09:16:18 -0700 (PDT) Received: from vitty.brq.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id f70sm8693222wme.22.2019.08.16.09.16.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 09:16:18 -0700 (PDT) From: Vitaly Kuznetsov To: Haiyang Zhang Cc: KY Srinivasan , Stephen Hemminger , "linux-kernel\@vger.kernel.org" , "sashal\@kernel.org" , "davem\@davemloft.net" , "saeedm\@mellanox.com" , "leon\@kernel.org" , "eranbe\@mellanox.com" , "lorenzo.pieralisi\@arm.com" , "bhelgaas\@google.com" , "linux-pci\@vger.kernel.org" , "linux-hyperv\@vger.kernel.org" , "netdev\@vger.kernel.org" Subject: RE: [PATCH net-next, 2/6] PCI: hv: Add a Hyper-V PCI mini driver for software backchannel interface In-Reply-To: References: <1565809632-39138-1-git-send-email-haiyangz@microsoft.com> <1565809632-39138-3-git-send-email-haiyangz@microsoft.com> <878srt8fd8.fsf@vitty.brq.redhat.com> Date: Fri, 16 Aug 2019 18:16:17 +0200 Message-ID: <871rxl84ry.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Haiyang Zhang writes: > > The pci_hyperv can only be loaded on VMs on Hyper-V and Azure. Other > drivers like MLX5e will have symbolic dependency of pci_hyperv if they > use functions exported by pci_hyperv. This dependency will cause other > drivers fail to load on other platforms, like VMs on KVM. So we created > this mini driver, which can be loaded on any platforms to provide the > symbolic dependency. (/me wondering is there a nicer way around this, by using __weak or something like that...) In case this stub is the best solution I'd suggest to rename it to something like PCI_HYPERV_INTERFACE to make it clear it is not a separate driver (_MINI makes me think so). -- Vitaly