From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: wire up memtest
Date: Fri, 28 Sep 2018 13:41:13 +1000 [thread overview]
Message-ID: <871s9euw4m.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <b3f2074b89ef0e3352fb11b69be30caeaa823fa0.1535360497.git.christophe.leroy@c-s.fr>
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Add call to early_memtest() so that kernel compiled with
> CONFIG_MEMTEST really perform memtest at startup when requested
> via 'memtest' boot parameter.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> arch/powerpc/kernel/setup-common.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
> index 93fa0c99681e..904b728eb20d 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -33,6 +33,7 @@
> #include <linux/serial_8250.h>
> #include <linux/percpu.h>
> #include <linux/memblock.h>
> +#include <linux/bootmem.h>
> #include <linux/of_platform.h>
> #include <linux/hugetlb.h>
> #include <asm/debugfs.h>
> @@ -917,6 +918,8 @@ void __init setup_arch(char **cmdline_p)
> /* Parse memory topology */
> mem_topology_setup();
>
> + early_memtest(min_low_pfn << PAGE_SHIFT, max_low_pfn << PAGE_SHIFT);
On a ppc64le VM this boils down to early_memtest(0, 0) for me.
I think it's too early, we don't set up max_low_pfn until
initmem_init().
If I move it after initmem_init() then it does something more useful:
early_memtest: # of tests: 17
0x0000000001450580 - 0x0000000001450800 pattern 4c494e5558726c7a
0x0000000001450c00 - 0x0000000003600000 pattern 4c494e5558726c7a
0x00000000047c0000 - 0x000000002fff0000 pattern 4c494e5558726c7a
0x0000000030000000 - 0x000000003ff24000 pattern 4c494e5558726c7a
0x000000003fff4000 - 0x000000003fff4c00 pattern 4c494e5558726c7a
0x000000003fff5000 - 0x000000003fff5300 pattern 4c494e5558726c7a
0x000000003fff5c00 - 0x000000003fff5f00 pattern 4c494e5558726c7a
0x000000003fff6800 - 0x000000003fff6b00 pattern 4c494e5558726c7a
0x000000003fff7400 - 0x000000003fff7700 pattern 4c494e5558726c7a
0x000000003fff8000 - 0x000000003fff8300 pattern 4c494e5558726c7a
0x000000003fff8c00 - 0x000000003fff8f00 pattern 4c494e5558726c7a
0x000000003fff9800 - 0x000000003fff9b00 pattern 4c494e5558726c7a
0x000000003fffa400 - 0x000000003fffa700 pattern 4c494e5558726c7a
0x000000003fffb000 - 0x000000003fffb300 pattern 4c494e5558726c7a
0x000000003fffbc00 - 0x000000003fffbf00 pattern 4c494e5558726c7a
0x000000003fffc800 - 0x000000003fffcb00 pattern 4c494e5558726c7a
0x000000003fffd400 - 0x000000003fffd700 pattern 4c494e5558726c7a
0x000000003fffe000 - 0x000000003fffe100 pattern 4c494e5558726c7a
0x0000000040000000 - 0x00000000ffc10000 pattern 4c494e5558726c7a
0x00000000fffa0000 - 0x00000000fffa5b00 pattern 4c494e5558726c7a
0x0000000100000000 - 0x00000001ffbe0000 pattern 4c494e5558726c7a
0x00000001fff60000 - 0x00000001fff61b00 pattern 4c494e5558726c7a
0x00000001fffec000 - 0x00000001fffec4b8 pattern 4c494e5558726c7a
0x00000001fffec524 - 0x00000001fffec528 pattern 4c494e5558726c7a
cheers
next prev parent reply other threads:[~2018-09-28 3:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 9:02 [PATCH] powerpc: wire up memtest Christophe Leroy
2018-09-28 3:41 ` Michael Ellerman [this message]
2018-09-28 8:28 ` Christophe LEROY
2018-09-28 12:44 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s9euw4m.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).