From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753325AbeDUT1q (ORCPT ); Sat, 21 Apr 2018 15:27:46 -0400 Received: from smtp13.smtpout.orange.fr ([80.12.242.135]:16979 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753158AbeDUT1p (ORCPT ); Sat, 21 Apr 2018 15:27:45 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 21 Apr 2018 21:27:44 +0200 X-ME-IP: 90.55.212.125 From: Robert Jarzmik To: Hans Verkuil Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, robert.jarzmik@free.fr Subject: Re: [PATCH 04/15] media: pxa_camera: remove the dmaengine compat need References: <20180402142656.26815-1-robert.jarzmik@free.fr> <20180402142656.26815-5-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 21 Apr 2018 21:27:43 +0200 In-Reply-To: <20180402142656.26815-5-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Mon, 2 Apr 2018 16:26:45 +0200") Message-ID: <871sf8z7f4.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Robert Jarzmik writes: > From: Robert Jarzmik > > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resource acquisition, using the more > generic function dma_request_slave_channel(). > > Signed-off-by: Robert Jarzmik > --- > drivers/media/platform/pxa_camera.c | 22 +++------------------- > 1 file changed, 3 insertions(+), 19 deletions(-) Hans, could I have your ack please ? Cheers. -- Robert PS: The submitted patch > > diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c > index c71a00736541..4c82d1880753 100644 > --- a/drivers/media/platform/pxa_camera.c > +++ b/drivers/media/platform/pxa_camera.c > @@ -2357,8 +2357,6 @@ static int pxa_camera_probe(struct platform_device *pdev) > .src_maxburst = 8, > .direction = DMA_DEV_TO_MEM, > }; > - dma_cap_mask_t mask; > - struct pxad_param params; > char clk_name[V4L2_CLK_NAME_SIZE]; > int irq; > int err = 0, i; > @@ -2432,34 +2430,20 @@ static int pxa_camera_probe(struct platform_device *pdev) > pcdev->base = base; > > /* request dma */ > - dma_cap_zero(mask); > - dma_cap_set(DMA_SLAVE, mask); > - dma_cap_set(DMA_PRIVATE, mask); > - > - params.prio = 0; > - params.drcmr = 68; > - pcdev->dma_chans[0] = > - dma_request_slave_channel_compat(mask, pxad_filter_fn, > - ¶ms, &pdev->dev, "CI_Y"); > + pcdev->dma_chans[0] = dma_request_slave_channel(&pdev->dev, "CI_Y"); > if (!pcdev->dma_chans[0]) { > dev_err(&pdev->dev, "Can't request DMA for Y\n"); > return -ENODEV; > } > > - params.drcmr = 69; > - pcdev->dma_chans[1] = > - dma_request_slave_channel_compat(mask, pxad_filter_fn, > - ¶ms, &pdev->dev, "CI_U"); > + pcdev->dma_chans[1] = dma_request_slave_channel(&pdev->dev, "CI_U"); > if (!pcdev->dma_chans[1]) { > dev_err(&pdev->dev, "Can't request DMA for Y\n"); > err = -ENODEV; > goto exit_free_dma_y; > } > > - params.drcmr = 70; > - pcdev->dma_chans[2] = > - dma_request_slave_channel_compat(mask, pxad_filter_fn, > - ¶ms, &pdev->dev, "CI_V"); > + pcdev->dma_chans[2] = dma_request_slave_channel(&pdev->dev, "CI_V"); > if (!pcdev->dma_chans[2]) { > dev_err(&pdev->dev, "Can't request DMA for V\n"); > err = -ENODEV;