From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
Haiyang Zhang <haiyangz@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
John Stultz <john.stultz@linaro.org>,
Alex Ng <alexng@microsoft.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH RFC] hv_utils: implement Hyper-V PTP source
Date: Fri, 13 Jan 2017 16:37:41 +0100 [thread overview]
Message-ID: <871sw72coq.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20170113152126.GA31625@aepfle.de> (Olaf Hering's message of "Fri, 13 Jan 2017 16:21:26 +0100")
Olaf Hering <olaf@aepfle.de> writes:
> On Fri, Jan 13, Vitaly Kuznetsov wrote:
>
>> + hv_ptp_clock = ptp_clock_register(&ptp_hyperv_info, NULL);
>> + if (IS_ERR(hv_ptp_clock)) {
>
> Should that be IS_ERR_OR_NULL to catch "!IS_REACHABLE(CONFIG_PTP_1588_CLOCK)"?
>
Oh, yes. I missed the case when CONFIG_PTP_1588_CLOCK is disabled
completely. I'll also remove the return below to not fail the device
completely. Even if there is no PTP support in kernel the
ICTIMESYNCFLAG_SYNC case which triggers do_settimeofday64() is still
probably useful.
--
Vitaly
next prev parent reply other threads:[~2017-01-13 15:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 17:24 [PATCH v2 0/4] hv_util: adjust system time smoothly Vitaly Kuznetsov
2017-01-04 17:24 ` [PATCH v2 1/4] timekeeping: export do_adjtimex() to modules Vitaly Kuznetsov
2017-01-07 1:06 ` John Stultz
2017-01-09 13:03 ` Vitaly Kuznetsov
2017-01-04 17:24 ` [PATCH v2 2/4] hv_util: switch to using timespec64 Vitaly Kuznetsov
2017-01-07 1:04 ` John Stultz
2017-01-04 17:24 ` [PATCH v2 3/4] hv_util: use do_adjtimex() to update system time Vitaly Kuznetsov
2017-01-04 19:09 ` Stephen Hemminger
2017-01-05 12:37 ` Vitaly Kuznetsov
2017-01-07 0:56 ` John Stultz
2017-01-04 17:24 ` [PATCH v2 4/4] hv_util: improve time adjustment accuracy by disabling interrupts Vitaly Kuznetsov
2017-01-04 19:17 ` Stephen Hemminger
2017-01-05 12:35 ` Vitaly Kuznetsov
2017-01-05 17:39 ` Stephen Hemminger
2017-01-07 1:02 ` John Stultz
2017-01-09 13:05 ` Vitaly Kuznetsov
2017-01-09 21:27 ` [PATCH v2 0/4] hv_util: adjust system time smoothly Thomas Gleixner
2017-01-10 14:30 ` Vitaly Kuznetsov
2017-01-10 14:58 ` Thomas Gleixner
2017-01-13 13:05 ` [PATCH RFC] hv_utils: implement Hyper-V PTP source Vitaly Kuznetsov
2017-01-13 14:50 ` Richard Cochran
2017-01-13 15:38 ` Vitaly Kuznetsov
2017-01-13 15:21 ` Olaf Hering
2017-01-13 15:37 ` Vitaly Kuznetsov [this message]
2017-01-16 19:29 ` Thomas Gleixner
2017-01-17 9:53 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sw72coq.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=alexng@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=john.stultz@linaro.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=stephen@networkplumber.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).