From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <damm+renesas@opensource.se>,
"Zhang Rui" <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Thao Phuong Le. Nguyen" <thao.nguyen.yb@rvc.renesas.com>,
Hien Dang <hien.dang.eb@renesas.com>,
Toru Oishi <toru.oishi.zj@renesas.com>
Subject: Re: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver
Date: Mon, 5 Sep 2016 01:09:15 +0000 [thread overview]
Message-ID: <871t0z40ub.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <SIXPR06MB09069C18D1F37BE5DB1284B3A8E40@SIXPR06MB0906.apcprd06.prod.outlook.com>
Hi
> Khiem Nguyen (5):
> thermal: rcar_gen3_thermal: Document the R-Car Gen3 thermal bindings
> thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver support
> arm64: dts: r8a7795: Add R-Car Gen3 thermal support
> arm64: dts: r8a7796: Add R-Car Gen3 thermal support
> arm64: defconfig: Enable R-Car Gen3 thermal support
For all patches
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> +static int rcar_gen3_thermal_get_temp(void *devdata, int *temp)
> +{
> + struct rcar_gen3_thermal_priv *priv = devdata;
> + int ctemp;
> + unsigned long flags;
> +
> + rcar_gen3_thermal_update_temp(priv);
> +
> + spin_lock_irqsave(&priv->lock, flags);
> + ctemp = _linear_temp_converter(priv->coef, priv->ctemp);
> + spin_unlock_irqrestore(&priv->lock, flags);
This is not a big deal, but, as I mentioned in v1 patch,
having pointer for _linear_temp_converter() parameter is good idea.
_linear_temp_converter(&priv->coef, xxx);
or
_linear_temp_converter(priv);
next prev parent reply other threads:[~2016-09-05 1:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 5:25 [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver Khiem Nguyen
2016-09-05 1:09 ` Kuninori Morimoto [this message]
2016-09-05 10:01 ` Geert Uytterhoeven
2016-09-06 12:19 ` Khiem Nguyen
2016-09-06 12:24 ` Geert Uytterhoeven
2016-09-06 0:51 ` Zhang Rui
2016-09-08 16:08 ` Khiem Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871t0z40ub.wl%kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=damm+renesas@opensource.se \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=geert+renesas@glider.be \
--cc=hien.dang.eb@renesas.com \
--cc=khiem.nguyen.xt@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thao.nguyen.yb@rvc.renesas.com \
--cc=toru.oishi.zj@renesas.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).