linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hitoshi Mitake <mitake.hitoshi@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Davidlohr Bueso <davidlohr@hp.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
	Aswin Chandramouleeswaran <aswin@hp.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/7] perf lock: plug some memleaks
Date: Thu, 19 Sep 2013 02:39:05 +0900	[thread overview]
Message-ID: <871u4mhvwm.wl%mitake.hitoshi@gmail.com> (raw)
In-Reply-To: <CALkWK0=MXws8DQKyynRwi02P3Hb83iJGzE16UmJ3rPzWqGS3UQ@mail.gmail.com>

At Mon, 9 Sep 2013 08:31:38 +0530,
Ramkumar Ramachandra wrote:
> 
> Davidlohr Bueso wrote:
> > diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> > index d318862..7784347 100644
> > --- a/tools/perf/builtin-lock.c
> > +++ b/tools/perf/builtin-lock.c
> > @@ -321,10 +321,12 @@ static struct lock_stat *lock_stat_findnew(void *addr, const char *name)
> >
> >         new->addr = addr;
> >         new->name = zalloc(sizeof(char) * strlen(name) + 1);
> > -       if (!new->name)
> > +       if (!new->name) {
> > +               free(new);
> >                 goto alloc_failed;
> > -       strcpy(new->name, name);
> > +       }
> 
> Why is the strcpy() missing indent?

The strcpy() is removed. It doesn't miss indantation.

Thanks,
Hitoshi

  reply	other threads:[~2013-09-18 17:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-09  2:19 [PATCH 0/7] perf lock: misc fixes and enhancements Davidlohr Bueso
2013-09-09  2:19 ` [PATCH 1/7] perf lock: remove dead code Davidlohr Bueso
2013-10-15  5:24   ` [tip:perf/core] perf lock: Remove " tip-bot for Davidlohr Bueso
2013-09-09  2:19 ` [PATCH 2/7] perf lock: return proper code in report_lock_*_event Davidlohr Bueso
2013-10-15  5:24   ` [tip:perf/core] perf lock: Return " tip-bot for Davidlohr Bueso
2013-09-09  2:19 ` [PATCH 3/7] perf lock: plug some memleaks Davidlohr Bueso
2013-09-09  3:01   ` Ramkumar Ramachandra
2013-09-18 17:39     ` Hitoshi Mitake [this message]
2013-10-15  5:24   ` [tip:perf/core] perf lock: Plug " tip-bot for Davidlohr Bueso
2013-09-09  2:19 ` [PATCH 4/7] perf lock: redo __cmd_report Davidlohr Bueso
2013-10-15  5:24   ` [tip:perf/core] perf lock: Redo __cmd_report tip-bot for Davidlohr Bueso
2013-09-09  2:19 ` [PATCH 5/7] perf lock: do not cut lock name Davidlohr Bueso
2013-09-18 17:38   ` Hitoshi Mitake
2013-09-09  2:19 ` [PATCH 6/7] perf lock: limit bad rate precision Davidlohr Bueso
2013-10-15  5:24   ` [tip:perf/core] perf lock: Limit " tip-bot for Davidlohr Bueso
2013-09-09  2:19 ` [PATCH 7/7] perf lock: account for lock average wait time Davidlohr Bueso
2013-10-15  5:24   ` [tip:perf/core] perf lock: Account " tip-bot for Davidlohr Bueso
2013-09-19 19:00 ` [PATCH 0/7] perf lock: misc fixes and enhancements Arnaldo Carvalho de Melo
2013-09-20  3:24   ` Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871u4mhvwm.wl%mitake.hitoshi@gmail.com \
    --to=mitake.hitoshi@gmail.com \
    --cc=acme@redhat.com \
    --cc=artagnon@gmail.com \
    --cc=aswin@hp.com \
    --cc=davidlohr@hp.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mitake@dcl.info.waseda.ac.jp \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).