From: Greg Gallagner <greg@embeddedgreg.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
devel@driverdev.osuosl.org,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] staging/bcm2835-audio: Fix alignment of function arguments - Style
Date: Wed, 8 Aug 2018 08:54:49 -0400 [thread overview]
Message-ID: <872dfe2f-59cf-baf9-490b-8b489c44ba5f@embeddedgreg.com> (raw)
In-Reply-To: <20180808122604.GA27932@kroah.com>
On 08/08/2018 08:26 AM, Greg Kroah-Hartman wrote:
> On Tue, Aug 07, 2018 at 09:40:47PM -0400, Greg Gallagher wrote:
>> Fix warnings generated by checkpatch.pl for alignment should match open
>> parenthesis. This is a coding style change only.
>>
>> Signed-off-by: Greg Gallagher <greg@embeddedgreg.com>
>> ---
>> Changes in v2:
>> - Clean up all the alignment warnings in the file
>> ---
>> .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
> You sent 2 patches that did the same thing, with different subjects :(
>
> Please fix up and send only the "correct" one.
>
> greg k-h
Sorry, the first one was a mistake and I should have sent something saying
to ignore it. I will double check the second one is correct. Is there
a best
practice when I'd like a patch ignored?
thanks
Greg
next prev parent reply other threads:[~2018-08-08 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 1:40 [PATCH v2] staging/bcm2835-audio: Fix alignment of function arguments - Style Greg Gallagher
2018-08-08 12:26 ` Greg Kroah-Hartman
2018-08-08 12:54 ` Greg Gallagner [this message]
2018-08-08 14:10 ` Greg Kroah-Hartman
2018-08-09 13:57 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=872dfe2f-59cf-baf9-490b-8b489c44ba5f@embeddedgreg.com \
--to=greg@embeddedgreg.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).