From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2572AC43334 for ; Tue, 14 Jun 2022 10:45:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242794AbiFNKph (ORCPT ); Tue, 14 Jun 2022 06:45:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235561AbiFNKpg (ORCPT ); Tue, 14 Jun 2022 06:45:36 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8234E46649 for ; Tue, 14 Jun 2022 03:45:34 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4LMlT5550Dz4xYC; Tue, 14 Jun 2022 20:45:29 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1655203529; bh=RBj66p9m4fPiE+NiL5b1xNhjr+ADnO+uqrgDmOY6ZfU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=KJBgz7Bti+zcSg0e6LuxnE3Y5fRvZA76Y4/AtP0VgEmK7oAUFmGkI6+3GGZPGNy9f YPxzzLCr5nBrazEUeqTH2NDUL2+blZa+/+pis7e4Ai9fFUnn663h3hTCMlqt0+JWka 1Ti6vNKngXZVyDw+ZPoC+aXcs4UnmEuHXI5SvDcr+DgHINxJpi83CKXyLp8Ztvt+lW TgtIhkmNKOc3pSTdt8ah4pBRRV5caZb1ROCRuR1fbdCfY7EamMhY11TXyyFmG5FpJR fsuwA0f3mlWzMjBQjhgtwZMxaV6h8QfXv0st6Q6sK5+pap3mPTLIOvZlj3vWsofwX/ h59qHks79R3fw== From: Michael Ellerman To: Wang Wenhu , gregkh@linuxfoundation.org, christophe.leroy@csgroup.eu Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Wang Wenhu Subject: Re: [PATCH 1/2] powerpc:mm: export symbol ioremap_coherent In-Reply-To: References: <20220609102855.272270-1-wenhu.wang@hotmail.com> Date: Tue, 14 Jun 2022 20:45:25 +1000 Message-ID: <8735g7cym2.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wang Wenhu writes: > The function ioremap_coherent may be called by modules such as > fsl_85xx_cache_sram. So export it for access in other modules. ioremap_coherent() is powerpc specific, and only has one other caller, I'd like to remove it. Does ioremap_cache() work for you? cheers > diff --git a/arch/powerpc/mm/ioremap.c b/arch/powerpc/mm/ioremap.c > index 4f12504fb405..08a00dacef0b 100644 > --- a/arch/powerpc/mm/ioremap.c > +++ b/arch/powerpc/mm/ioremap.c > @@ -40,6 +40,7 @@ void __iomem *ioremap_coherent(phys_addr_t addr, unsigned long size) > return iowa_ioremap(addr, size, prot, caller); > return __ioremap_caller(addr, size, prot, caller); > } > +EXPORT_SYMBOL(ioremap_coherent); > > void __iomem *ioremap_prot(phys_addr_t addr, unsigned long size, unsigned long flags) > { > -- > 2.25.1