From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C710C4332F for ; Wed, 11 May 2022 08:10:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243327AbiEKIKG (ORCPT ); Wed, 11 May 2022 04:10:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233633AbiEKIKA (ORCPT ); Wed, 11 May 2022 04:10:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ECB19C2E0 for ; Wed, 11 May 2022 01:09:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ABC3C61A3D for ; Wed, 11 May 2022 08:09:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17280C385DB; Wed, 11 May 2022 08:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652256598; bh=FVh96bdERwMwqAkQyYyRnk6K/ep94wX0XFLfJEym+cM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iJ1axJyM4OoVOVXWrUWJWgalkzdJrg8vdUgHhLNZyhrb9hR4j3wOVNEGMMnCjrfSo 4/HKJ8Il5TRRp9TS2Dq9XY2UMPvQs2PPSjcm0UEvTb2yqFWA6/jkAjTitCMDn1K0Sy 032dD9XBXxCjiRBP89Gz6AXrnHakLOZkETxewYphqv6so3v+5LChhIYrqtUNzJ+p2f FURE+6mIYrrkiOk8Tpub/P4uCtf+TLzbSnlxAVadc0ox9OwHoNNDEQx4ZOs9pR4L3U 7hZAJLK/L0lv0uhrnBQAaTYcCTfPfZIidGhkCpUhaYBQ3btQ5wFPqJ4VsNMJlRGpg8 b33ij/WUNm+NQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nohPv-00ATrM-Gm; Wed, 11 May 2022 09:09:55 +0100 Date: Wed, 11 May 2022 09:09:55 +0100 Message-ID: <8735hg7ang.wl-maz@kernel.org> From: Marc Zyngier To: Antonio Borneo Cc: Thomas Gleixner , Maxime Coquelin , Alexandre Torgue , , , , Ludovic Barre , Loic Pallardy , Pascal Paillet Subject: Re: [PATCH 1/7] irqchip/stm32-exti: set_affinity return IRQ_SET_MASK_OK_DONE if no parent In-Reply-To: <05d9a88de4a7c415545043fab1e577e7f6151b8c.camel@foss.st.com> References: <20220510164123.557921-1-antonio.borneo@foss.st.com> <878rr96xuo.wl-maz@kernel.org> <05d9a88de4a7c415545043fab1e577e7f6151b8c.camel@foss.st.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: antonio.borneo@foss.st.com, tglx@linutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, ludovic.barre@foss.st.com, loic.pallardy@foss.st.com, p.paillet@foss.st.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 May 2022 07:39:43 +0100, Antonio Borneo wrote: >=20 > Hi Marc, >=20 > On Tue, 2022-05-10 at 19:34 +0100, Marc Zyngier wrote: > > Antonio, > >=20 > > On Tue, 10 May 2022 17:41:17 +0100, > > Antonio Borneo wrote: > > >=20 > > > From: Ludovic Barre > > >=20 > > > If no parent, there is no specific action to do in > > > stm32 irqchip, and so return IRQ_SET_MASK_OK_DONE. > > >=20 > > > Signed-off-by: Ludovic Barre > > > Signed-off-by: Antonio Borneo > > > --- > > > =C2=A0drivers/irqchip/irq-stm32-exti.c | 2 +- > > > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/drivers/irqchip/irq-stm32-exti.c > > > b/drivers/irqchip/irq-stm32-exti.c > > > index 9d18f47040eb..10c9c742c216 100644 > > > --- a/drivers/irqchip/irq-stm32-exti.c > > > +++ b/drivers/irqchip/irq-stm32-exti.c > > > @@ -614,7 +614,7 @@ static int stm32_exti_h_set_affinity(struct > > > irq_data *d, > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (d->parent_data->c= hip) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0return irq_chip_set_affinity_parent(d, dest, > > > force); > > > =C2=A0 > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return -EINVAL; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return IRQ_SET_MASK_OK_DON= E; > > > =C2=A0} > > > =C2=A0 > > > =C2=A0static int __maybe_unused stm32_exti_h_suspend(void) > >=20 > > > > Can you *please* use a cover-letter when sending more that a single > > patch? I expect there is an overarching motive to this series. Where > > is it described? > >=20 > > Also, please look at the way the subject lines are written for most > > irqchip patches: > >=20 > > irqchip/foo: Frobify the bar callback return value > >=20 > > Note the capital letter after the ':', and the fact that it starts > > with a verb. Here, I would have liked to see: > >=20 > > irqchip/stm32-exti: Fix set_affinity() return value > >=20 > > and leave the meat of the description to the commit log (instead of > > saying the exact same thing twice). > > >=20 > thanks for your review and the hints on this series. > I will shortly send a V2. No rush. I'm about to close the 5.19 irqchip tree. Thanks, M. --=20 Without deviation from the norm, progress is not possible.