From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E00CDC433EF
	for <linux-kernel@archiver.kernel.org>; Thu, 25 Nov 2021 19:04:39 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1350034AbhKYTHr (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 25 Nov 2021 14:07:47 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35542 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1350057AbhKYTFq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 Nov 2021 14:05:46 -0500
Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE0D8C061746;
        Thu, 25 Nov 2021 11:02:34 -0800 (PST)
From:   Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020; t=1637866952;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=T2XxSbGmOETo/1xgmmcSAzfWmmIjkyNEg8evDzTjJq0=;
        b=NQULa9X3po7Ns6LXdqV6rPSwg71DXnQBLl/L+KXsUdHndmwLTv3Cx9FV8SDGIesqN/obbO
        Ootq4trFyFRcM9ZAgwPegBS38vgbclX/kPXah6D573VvkBlc5PLdJBJMfadrAsFv5RsoYl
        B4TMsLGcipP8eR6dap1VYYo7gin7xdfN8SsbfyqwZAAlW66CwdYsF8Nj6pv8C0pgx60TiS
        igH7F5tmNXlpqzyk8K2WdyKgsTkL8icAQNdNtyITBdWi18emZGHiSWVIJtqUjJQklRNOIO
        LZ0oRY2O6xN82p7FM4Rtzr1pMdmoXLlZFQ8UPZwr8mQqcH96u8yhdxs2ANEXAA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020e; t=1637866952;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=T2XxSbGmOETo/1xgmmcSAzfWmmIjkyNEg8evDzTjJq0=;
        b=G8qVjTGkkC3XPiDR57L960IIfQOFtzeAJ3zNoL2Uoh3mT7x4by2XrtKWHPJktuMYwTIYuW
        jM+DGTreoopjzGBg==
To:     isaku.yamahata@intel.com, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, erdemaktas@google.com,
        Connor Kuehl <ckuehl@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc:     isaku.yamahata@intel.com, isaku.yamahata@gmail.com,
        Sean Christopherson <sean.j.christopherson@intel.com>
Subject: Re: [RFC PATCH v3 09/59] KVM: Enable hardware before doing arch VM
 initialization
In-Reply-To: <0763173807466be61a823cd30c2c334adecb0a95.1637799475.git.isaku.yamahata@intel.com>
References: <cover.1637799475.git.isaku.yamahata@intel.com>
 <0763173807466be61a823cd30c2c334adecb0a95.1637799475.git.isaku.yamahata@intel.com>
Date:   Thu, 25 Nov 2021 20:02:31 +0100
Message-ID: <8735nkkqig.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 24 2021 at 16:19, isaku yamahata wrote:
> From: Sean Christopherson <sean.j.christopherson@intel.com>
>
> Swap the order of hardware_enable_all() and kvm_arch_init_vm() to
> accommodate Intel's TDX, which needs VMX to be enabled during VM init in
> order to make SEAMCALLs.
>
> This also provides consistent ordering between kvm_create_vm() and
> kvm_destroy_vm() with respect to calling kvm_arch_destroy_vm() and
> hardware_disable_all().

So far so good. This should also explain that there is no downside with
that order change especially as this order has been that way for a long
time.

Thanks,

      tglx