From: Cornelia Huck <cohuck@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Tony Krowiak <akrowiak@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
pasic@linux.vnet.ibm.com, jjherne@linux.ibm.com, jgg@nvidia.com,
kwankhede@nvidia.com, david@redhat.com, pbonzini@redhat.com,
frankja@linux.ibm.com, imbrenda@linux.ibm.com
Subject: Re: [PATCH 0/2] s390/vfio-ap: do not open code locks for VFIO_GROUP_NOTIFY_SET_KVM notification
Date: Thu, 19 Aug 2021 17:30:21 +0200 [thread overview]
Message-ID: <8735r5sb8y.fsf@redhat.com> (raw)
In-Reply-To: <20210818103908.31eb5848.alex.williamson@redhat.com>
On Wed, Aug 18 2021, Alex Williamson <alex.williamson@redhat.com> wrote:
> On Wed, 18 Aug 2021 17:59:51 +0200
> Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>
>> On 02.08.21 18:32, Tony Krowiak wrote:
>> >
>> >
>> > On 8/2/21 9:53 AM, Halil Pasic wrote:
>> >> On Mon, 2 Aug 2021 09:10:26 -0400
>> >> Tony Krowiak <akrowiak@linux.ibm.com> wrote:
>> >>
>> >>> PING!
>> >>>
>> >>> This patch will pre-req version 17 of a patch series I have waiting in
>> >>> the wings,
>> >>> so I'd like to get this one merged ASAP. In particular, if a KVM
>> >>> maintainer can
>> >>> take a look at the comments concerning the taking of the kvm->lock
>> >>> before the
>> >>> matrix_mdev->lock it would be greatly appreciated. Those comments begin with
>> >>> Message ID <20210727004329.3bcc7d4f.pasic@linux.ibm.com> from Halil Pasic.
>> >> As far as I'm concerned, we can move forward with this. Was this
>> >> supposed to go in via Alex's tree?
>> >
>> > I am not certain, Christian queued the previous patches related to
>> > this on:
>> >
>> >
>> > https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/log/?h=fixes
>> >
>> > Jason G., since this will need to be integrated with your other patches,
>> > where should this be queued?
>>
>>
>> This previous patch (s390/vfio-ap: clean up mdev resources when remove callback invoked) is
>> already in master.
>> Can you respin the series with all Acks and RBs?
>>
>> Alex, can you then take these 2 patches via your tree? Thanks
>>
>> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> for this series.
>
>
> I see some review feedback that seems to suggest a new version would be
> posted:
>
> https://lore.kernel.org/linux-s390/0f03ab0b-2dfd-e1c1-fe43-be2a59030a71@linux.ibm.com/
Yeah, I thought so as well. But it also looks like something that could
be a fixup on top.
>
> I also see in this thread:
>
> https://lore.kernel.org/linux-s390/20210721164550.5402fe1c.pasic@linux.ibm.com/
>
> that Halil's concern's around open/close races are addressed by Jason's
> device_open/close series that's already in my next branch and he
> provided an Ack, but there's still the above question regarding the
> kvm->lock that was looking for a review from... I'm not sure, maybe
> Connie or Paolo. Christian, is this specifically what you're ack'ing?
I'm also unsure about the kvm->lock thing. Is taking the lock buried
somewhere deep in the code that will ultimately trigger the release?
I would at least like a pointer.
>
> It can ultimately go in through my tree, but not being familiar with
> this code I'd hope for more closure. Thanks,
>
> Alex
next prev parent reply other threads:[~2021-08-19 15:30 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 19:35 [PATCH 0/2] s390/vfio-ap: do not open code locks for VFIO_GROUP_NOTIFY_SET_KVM notification Tony Krowiak
2021-07-19 19:35 ` [PATCH 1/2] s390/vfio-ap: r/w lock for PQAP interception handler function pointer Tony Krowiak
2021-08-18 17:03 ` Christian Borntraeger
2021-08-18 23:25 ` Halil Pasic
2021-08-19 6:56 ` Christian Borntraeger
2021-08-19 13:36 ` Tony Krowiak
2021-08-19 21:42 ` Halil Pasic
2021-08-23 13:08 ` Tony Krowiak
2021-08-19 13:20 ` Tony Krowiak
2021-08-19 17:54 ` Alex Williamson
2021-08-19 17:58 ` Jason Gunthorpe
2021-08-20 15:59 ` Tony Krowiak
2021-08-20 22:05 ` Tony Krowiak
2021-08-20 22:30 ` Jason Gunthorpe
2021-08-23 15:17 ` Tony Krowiak
2021-08-20 22:41 ` Alex Williamson
2021-08-23 20:51 ` Tony Krowiak
2021-07-19 19:35 ` [PATCH 2/2] s390/vfio-ap: replace open coded locks for VFIO_GROUP_NOTIFY_SET_KVM notification Tony Krowiak
2021-07-21 14:45 ` Halil Pasic
2021-07-22 13:09 ` Tony Krowiak
2021-07-23 14:26 ` Halil Pasic
2021-07-23 21:24 ` Tony Krowiak
2021-07-26 20:36 ` Halil Pasic
2021-07-26 22:03 ` Jason Gunthorpe
2021-07-26 22:43 ` Halil Pasic
2021-07-28 13:43 ` Tony Krowiak
2021-07-28 19:42 ` Halil Pasic
2021-07-30 13:33 ` Tony Krowiak
2021-07-27 6:54 ` Christoph Hellwig
2021-07-21 19:37 ` Jason J. Herne
2021-07-22 13:16 ` Tony Krowiak
2021-08-02 13:10 ` [PATCH 0/2] s390/vfio-ap: do not open code " Tony Krowiak
2021-08-02 13:53 ` Halil Pasic
2021-08-02 16:32 ` Tony Krowiak
2021-08-03 13:08 ` Jason Gunthorpe
2021-08-03 13:34 ` Tony Krowiak
2021-08-18 15:59 ` Christian Borntraeger
2021-08-18 16:39 ` Alex Williamson
2021-08-18 16:50 ` Christian Borntraeger
2021-08-18 22:52 ` Halil Pasic
2021-08-19 15:30 ` Cornelia Huck [this message]
2021-08-20 14:24 ` Tony Krowiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735r5sb8y.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jgg@nvidia.com \
--cc=jjherne@linux.ibm.com \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).