From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79455C4338F for ; Fri, 23 Jul 2021 15:28:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 529F160EBD for ; Fri, 23 Jul 2021 15:28:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235567AbhGWOrI (ORCPT ); Fri, 23 Jul 2021 10:47:08 -0400 Received: from foss.arm.com ([217.140.110.172]:47428 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235501AbhGWOqd (ORCPT ); Fri, 23 Jul 2021 10:46:33 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2962112FC; Fri, 23 Jul 2021 08:27:07 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5B5D43F73D; Fri, 23 Jul 2021 08:27:06 -0700 (PDT) From: Valentin Schneider To: Arnd Bergmann , Ingo Molnar Cc: Arnd Bergmann , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [PATCH] smpboot: remove duplicate inline keyword In-Reply-To: <20210723091618.1750551-1-arnd@kernel.org> References: <20210723091618.1750551-1-arnd@kernel.org> Date: Fri, 23 Jul 2021 16:27:01 +0100 Message-ID: <8735s5m4oq.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 23/07/21 11:16, Arnd Bergmann wrote: > From: Arnd Bergmann > > 'static inline void __always_inline' is one more 'inline' than needed, > and it's in the wrong place as gcc points out when extra warnings > are enabled: > > kernel/smpboot.c:50:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration] > 50 | static inline void __always_inline idle_init(unsigned int cpu) > > Move it to the right place instead. > > Fixes: e9ba16e68cce ("smpboot: Mark idle_init() as __always_inlined to work around aggressive compiler un-inlining") > Signed-off-by: Arnd Bergmann Colin sent a similar fix at: http://lore.kernel.org/r/20210715164018.62712-1-colin.king@canonical.com Now AFAICT the incriminated patch is in tip/core/urgent and linux-next/master, but not in the current mainline. If so, this could be fixed up before it gets pulled.