From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA97C4363F for ; Wed, 5 May 2021 17:21:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7380F60FD7 for ; Wed, 5 May 2021 17:21:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240576AbhEERVY (ORCPT ); Wed, 5 May 2021 13:21:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:33118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235458AbhEERGT (ORCPT ); Wed, 5 May 2021 13:06:19 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E926B61157; Wed, 5 May 2021 16:49:43 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1leKiT-00B3BN-RZ; Wed, 05 May 2021 17:49:41 +0100 Date: Wed, 05 May 2021 17:49:41 +0100 Message-ID: <8735v1nn16.wl-maz@kernel.org> From: Marc Zyngier To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andrew Scull , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH AUTOSEL 5.12 039/116] KVM: arm64: Use BUG and BUG_ON in nVHE hyp In-Reply-To: <20210505163125.3460440-39-sashal@kernel.org> References: <20210505163125.3460440-1-sashal@kernel.org> <20210505163125.3460440-39-sashal@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: sashal@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, ascull@google.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 05 May 2021 17:30:07 +0100, Sasha Levin wrote: > > From: Andrew Scull > > [ Upstream commit f79e616f27ab6cd74deb0995a8eead3d1c9d65af ] > > hyp_panic() reports the address of the panic by using ELR_EL2, but this > isn't a useful address when hyp_panic() is called directly. Replace such > direct calls with BUG() and BUG_ON() which use BRK to trigger an > exception that then goes to hyp_panic() with the correct address. Also > remove the hyp_panic() declaration from the header file to avoid > accidental misuse. > > Signed-off-by: Andrew Scull > Acked-by: Will Deacon > Signed-off-by: Marc Zyngier > Link: https://lore.kernel.org/r/20210318143311.839894-5-ascull@google.com > Signed-off-by: Sasha Levin Same this for this patch. M. -- Without deviation from the norm, progress is not possible.