From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93311C43461 for ; Sat, 5 Sep 2020 11:04:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 648BF2074B for ; Sat, 5 Sep 2020 11:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599303859; bh=W7V8ZU7QH4bhyjnEuCPx/ysHegXohN29y01K74kjKS8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=KfpmBxOe0lOu9uBvpT98ls40wK6gS0Jt/B9JxvKUnTVOF1hDI6jhqxv0CgIQS/NLo +2k0XpSg3fR0j8sj5fzwioMVF9GEJJ06JCVr+ouJptLnXOWlmDHKeJSXnZZbKPujlc 6Dqq40jErvSSNyQKQM16utr0HScCMgR8aAe5Qfh4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728509AbgIELEQ (ORCPT ); Sat, 5 Sep 2020 07:04:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:57778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726597AbgIELEO (ORCPT ); Sat, 5 Sep 2020 07:04:14 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE1932074B; Sat, 5 Sep 2020 11:04:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599303853; bh=W7V8ZU7QH4bhyjnEuCPx/ysHegXohN29y01K74kjKS8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZMH/9Dxi3qJfkhd7VLtbaguJfgBtdzMSQCGEujpCfOvhFG2+ePwZNWWEC3jCpJtyO qwWscifFtIwxsOvPw/yUPISHf+t+7GNXTNmFEUmy1Tyu+O9SHMxJ1DRfH9XUkW6mSl ZTCI6cAdDwK2idzR/d2ukgq/nOaU49BF6d4dwUAQ= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEVzP-009M5B-VJ; Sat, 05 Sep 2020 12:04:12 +0100 Date: Sat, 05 Sep 2020 12:04:10 +0100 Message-ID: <87363wmqmt.wl-maz@kernel.org> From: Marc Zyngier To: Jianyong Wu Cc: netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com, sean.j.christopherson@intel.com, richardcochran@gmail.com, Mark.Rutland@arm.com, will@kernel.org, suzuki.poulose@arm.com, steven.price@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Steve.Capper@arm.com, justin.he@arm.com, nd@arm.com Subject: Re: [PATCH v14 07/10] arm64/kvm: Add hypercall service for kvm ptp. In-Reply-To: <20200904092744.167655-8-jianyong.wu@arm.com> References: <20200904092744.167655-1-jianyong.wu@arm.com> <20200904092744.167655-8-jianyong.wu@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: jianyong.wu@arm.com, netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com, sean.j.christopherson@intel.com, richardcochran@gmail.com, Mark.Rutland@arm.com, will@kernel.org, suzuki.poulose@arm.com, steven.price@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Steve.Capper@arm.com, justin.he@arm.com, nd@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 04 Sep 2020 10:27:41 +0100, Jianyong Wu wrote: > > ptp_kvm will get this service through smccc call. > The service offers wall time and counter cycle of host for guest. > caller must explicitly determines which cycle of virtual counter or > physical counter to return if it needs counter cycle. > > Signed-off-by: Jianyong Wu > --- > arch/arm64/kvm/Kconfig | 6 +++++ > arch/arm64/kvm/arch_timer.c | 2 +- > arch/arm64/kvm/hypercalls.c | 49 ++++++++++++++++++++++++++++++++++++ > include/kvm/arm_arch_timer.h | 1 + > include/linux/arm-smccc.h | 16 ++++++++++++ > 5 files changed, 73 insertions(+), 1 deletion(-) > [...] On top of what I said yesterday: > index 32ba6fbc3814..eb85f6701845 100644 > --- a/arch/arm64/kvm/arch_timer.c > +++ b/arch/arm64/kvm/arch_timer.c > @@ -81,7 +81,7 @@ u64 timer_get_cval(struct arch_timer_context *ctxt) > } > } > > -static u64 timer_get_offset(struct arch_timer_context *ctxt) > +u64 timer_get_offset(struct arch_timer_context *ctxt) > { > struct kvm_vcpu *vcpu = ctxt->vcpu; > Why has this become global? I can't see a reason why we would want to expose this purely KVM internal helper. M. -- Without deviation from the norm, progress is not possible.