From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2356EC2BA83 for ; Wed, 12 Feb 2020 14:24:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F28DE20873 for ; Wed, 12 Feb 2020 14:24:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728383AbgBLOYt (ORCPT ); Wed, 12 Feb 2020 09:24:49 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:49015 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727963AbgBLOYs (ORCPT ); Wed, 12 Feb 2020 09:24:48 -0500 Received: from localhost ([127.0.0.1] helo=vostro.local) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1j1swX-0006Bj-Uq; Wed, 12 Feb 2020 15:24:46 +0100 From: John Ogness To: Petr Mladek Cc: Sergey Senozhatsky , Andy Shevchenko , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH v1] printk: Declare log_wait as external variable References: <20200203131528.52825-1-andriy.shevchenko@linux.intel.com> <20200211124317.x5erhl7kvxj2nq6a@pathway.suse.cz> <20200212013133.GB13208@google.com> <20200212140355.56drih2wfcryjjtl@pathway.suse.cz> Date: Wed, 12 Feb 2020 15:24:44 +0100 In-Reply-To: <20200212140355.56drih2wfcryjjtl@pathway.suse.cz> (Petr Mladek's message of "Wed, 12 Feb 2020 15:03:55 +0100") Message-ID: <8736bfdgsz.fsf@linutronix.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-02-12, Petr Mladek wrote: > I would prefer to split it: > > + printk.c is already too big and would deserve splitting. > > + The two different kmgs interfaces are confusing on its > own. IMHO, it will be even more confusing when they > live in one huge source file. > > >> I can take a look at dev_ksmg.c/proc_kmsg.c option, unless >> someone else wants to spend their time on this. > > It would be lovely from my POV. I am only concerned about > the lockless printk() stuff. I would prefer to avoid creating > too many conflicts in the same merge window. Well, I am > not sure how many conflicts there would be. Adding John > into CC. I would also love to see these changes. But can we _please_ focus on the lockless printk ringbuffer merge first? The patches already exist and are (hopefully) being reviewed. I would prefer that such a heavy API replacement is done _before_ we start any massive refactoring. John Ogness