linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] x86/boot/KASLR: Fix unused variable warning
@ 2020-01-03  3:39 Zhenzhong Duan
  2020-01-09 18:40 ` Borislav Petkov
  2020-01-09 21:00 ` Thomas Gleixner
  0 siblings, 2 replies; 15+ messages in thread
From: Zhenzhong Duan @ 2020-01-03  3:39 UTC (permalink / raw)
  To: linux-kernel
  Cc: x86, Zhenzhong Duan, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H. Peter Anvin, Chao Fan, Dave Hansen,
	Rafael J. Wysocki

Local variable 'i' is referenced only when CONFIG_MEMORY_HOTREMOVE and
CONFIG_ACPI are defined, but definition of variable 'i' is out of guard.
If any of the two macros is undefined, below warning triggers during
build, fix it by moving 'i' in the guard.

arch/x86/boot/compressed/kaslr.c:698:6: warning: unused variable ‘i’ [-Wunused-variable]

Also use true/false instead of 1/0 for boolean return.

Fixes: 690eaa532057 ("x86/boot/KASLR: Limit KASLR to extract the kernel in immovable memory only")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Chao Fan <fanc.fnst@cn.fujitsu.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
---
v2: update description per Boris.

 arch/x86/boot/compressed/kaslr.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
index d7408af55738..fff24a55bfd5 100644
--- a/arch/x86/boot/compressed/kaslr.c
+++ b/arch/x86/boot/compressed/kaslr.c
@@ -695,7 +695,6 @@ static bool process_mem_region(struct mem_vector *region,
 			       unsigned long long minimum,
 			       unsigned long long image_size)
 {
-	int i;
 	/*
 	 * If no immovable memory found, or MEMORY_HOTREMOVE disabled,
 	 * use @region directly.
@@ -705,12 +704,13 @@ static bool process_mem_region(struct mem_vector *region,
 
 		if (slot_area_index == MAX_SLOT_AREA) {
 			debug_putstr("Aborted e820/efi memmap scan (slot_areas full)!\n");
-			return 1;
+			return true;
 		}
-		return 0;
+		return false;
 	}
 
 #if defined(CONFIG_MEMORY_HOTREMOVE) && defined(CONFIG_ACPI)
+	int i;
 	/*
 	 * If immovable memory found, filter the intersection between
 	 * immovable memory and @region.
@@ -734,11 +734,11 @@ static bool process_mem_region(struct mem_vector *region,
 
 		if (slot_area_index == MAX_SLOT_AREA) {
 			debug_putstr("Aborted e820/efi memmap scan when walking immovable regions(slot_areas full)!\n");
-			return 1;
+			return true;
 		}
 	}
 #endif
-	return 0;
+	return false;
 }
 
 #ifdef CONFIG_EFI
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2020-01-24 11:43 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-03  3:39 [PATCH v2] x86/boot/KASLR: Fix unused variable warning Zhenzhong Duan
2020-01-09 18:40 ` Borislav Petkov
2020-01-09 20:46   ` Arvind Sankar
2020-01-09 20:50     ` Borislav Petkov
2020-01-10  2:09       ` Zhenzhong Duan
2020-01-10  8:27         ` Borislav Petkov
2020-01-10  8:36           ` Zhenzhong Duan
2020-01-10  9:01             ` Borislav Petkov
2020-01-10  2:27     ` Zhenzhong Duan
2020-01-10  9:00       ` Borislav Petkov
2020-01-13  2:43         ` Zhenzhong Duan
2020-01-24 11:09           ` Borislav Petkov
2020-01-09 21:00 ` Thomas Gleixner
2020-01-10  8:46   ` Zhenzhong Duan
2020-01-10 13:13     ` Thomas Gleixner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).