linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@savoirfairelinux.com, f.fainelli@gmail.com,
	andrew@lunn.ch
Subject: Re: [PATCH net-next 0/5] net: dsa: use per-port upstream port
Date: Tue, 05 Dec 2017 14:57:18 -0500	[thread overview]
Message-ID: <87374pdk2p.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20171205.144727.522098543209254657.davem@davemloft.net>

Hi David,

David Miller <davem@davemloft.net> writes:

> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> Date: Mon,  4 Dec 2017 12:34:52 -0500
>
>> An upstream port is a local switch port used to reach a CPU port.
>> 
>> DSA still considers a unique CPU port in the whole switch fabric and
>> thus return a unique upstream port for a given switch. This is wrong in
>> a multiple CPU ports environment.
>> 
>> We are now switching to using the dedicated CPU port assigned to each
>> port in order to get rid of the deprecated unique tree CPU port.
>> 
>> This patchset makes the dsa_upstream_port() helper take a port argument
>> and goes one step closer complete support for multiple CPU ports.
>
> Please adhere to reverse-christmas-tree for variable declarations in
> these changes.

Totally makes sense for this month of the year, I'm replanting a v2!


Thanks,

        Vivien

      reply	other threads:[~2017-12-05 19:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04 17:34 [PATCH net-next 0/5] net: dsa: use per-port upstream port Vivien Didelot
2017-12-04 17:34 ` [PATCH net-next 1/5] net: dsa: mv88e6xxx: egress floods all DSA ports Vivien Didelot
2017-12-04 17:34 ` [PATCH net-next 2/5] net: dsa: mv88e6xxx: helper to setup upstream port Vivien Didelot
2017-12-04 17:34 ` [PATCH net-next 3/5] net: dsa: mv88e6xxx: setup global " Vivien Didelot
2017-12-04 17:34 ` [PATCH net-next 4/5] net: dsa: assign a CPU port to DSA port Vivien Didelot
2017-12-04 17:34 ` [PATCH net-next 5/5] net: dsa: return per-port upstream port Vivien Didelot
2017-12-05 19:47 ` [PATCH net-next 0/5] net: dsa: use " David Miller
2017-12-05 19:57   ` Vivien Didelot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87374pdk2p.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).