From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbdHHGO5 (ORCPT ); Tue, 8 Aug 2017 02:14:57 -0400 Received: from mga05.intel.com ([192.55.52.43]:33414 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbdHHGO4 (ORCPT ); Tue, 8 Aug 2017 02:14:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,341,1498546800"; d="scan'208";a="137565511" From: Felipe Balbi To: Lu Baolu , Mathias Nyman , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to usb/common In-Reply-To: <59891304.6050803@linux.intel.com> References: <1502093269-15978-1-git-send-email-baolu.lu@linux.intel.com> <1502093269-15978-3-git-send-email-baolu.lu@linux.intel.com> <87inhzaj8t.fsf@linux.intel.com> <59891304.6050803@linux.intel.com> Date: Tue, 08 Aug 2017 09:14:23 +0300 Message-ID: <8737927fi8.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Lu Baolu writes: >> Lu Baolu writes: >>> The component u_serial provides a glue layer between TTY layer >>> and a USB gadget device needed to provide a basic serial port >>> functionality. Currently, u_serial sits under gadget/function >>> and depends on CONFIG_USB_GADGET to be compiled and used. >>> >>> Most of the serial gadget devices are based on a UDC (USB device >>> controller) and implemented by making use of the Linux gadget >>> frameworks. But we are facing other implementions as well. One >>> example can be found with xHCI debug capability. The xHCI debug >>> capability implements a serial gadget with hardware and firmware, >>> and provides an interface similar with xHCI host for submitting >>> and reaping the transfer requests. >>> >>> In order to make better use of u_serial when implementing xHCI >>> debug capability in xHCI driver, this patch moves u_serial.c >>> from gadget/function to usb/common, and moves u_serial.h from >>> gadget/function to include/linux/usb. >>> >>> Signed-off-by: Lu Baolu >> NAK, u_serial uses the gadget API. It's definitely not COMMON. >> > > Okay. It seems that I can't use u_serial anyway. I will implement > a new tty glue for my case. have you looked at drivers/usb/serial/? -- balbi