From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932790AbdA0M3N (ORCPT ); Fri, 27 Jan 2017 07:29:13 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:42662 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932655AbdA0M1v (ORCPT ); Fri, 27 Jan 2017 07:27:51 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D3906607E3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Pali =?utf-8?Q?Roh=C3=A1r?= Cc: Arend Van Spriel , Ming Lei , "Luis R. Rodriguez" , Greg Kroah-Hartman , David Gnedt , Michal Kazior , Daniel Wagner , Tony Lindgren , Sebastian Reichel , Pavel Machek , Ivaylo Dimitrov , Aaro Koskinen , Grazvydas Ignotas , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data References: <1482598381-16513-1-git-send-email-pali.rohar@gmail.com> <1482598381-16513-3-git-send-email-pali.rohar@gmail.com> <87tw8lnei3.fsf@codeaurora.org> <20170127094342.GC24223@pali> <20170127101043.GD24223@pali> <20170127103408.GG24223@pali> <87bmus7mfk.fsf@kamboji.qca.qualcomm.com> <20170127115706.GH24223@pali> Date: Fri, 27 Jan 2017 14:26:22 +0200 In-Reply-To: <20170127115706.GH24223@pali> ("Pali \=\?utf-8\?Q\?Roh\=C3\=A1r\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 27 Jan 2017 12:57:06 +0100") Message-ID: <8737g47kpd.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0RCVgHr025546 Pali Rohár writes: > On Friday 27 January 2017 13:49:03 Kalle Valo wrote: >> Pali Rohár writes: >> >> >> So >> >> for those other platforms there will be a delay waiting for user-mode >> >> helper to fail, before trying to get nvs file from /lib/firmware. >> > >> > Yes, there will be. But there is no easy way to fix this problem that >> > kernel is trying to use default/example NVS data... >> >> Kernel is doing correctly and requesting NVS data as expected, the >> problem here is that linux-firmware claims that the example NVS data is >> real calibration data (which it is not). Distros should not use that, >> only developers for testing purposes. We should not courage users using >> example calibration data. >> >> The simple fix is to rename the NVS file in linux-firmware to something >> like wl1251-nvs.bin.example, no need to workaround this in kernel. If >> you send a patch to linux-firmware I'm happy to ack that. > > I agree with rename and fact that default/example data should not be > used. > > But... > > 1) Kernel should not read device/model specific data from VFS where > are stored not-device-specific files preinstalled by linux > distributions. > > And linux distributions are already putting files into VFS and kernel > cannot enforce userspace to not do that (as they are already doing it). I'm having problems to understand what you are saying here. > 2) It was already tested that example NVS data can be used for N900 e.g. > for SSH connection. If real correct data are not available it is better > to use at least those example (and probably log warning message) so user > can connect via SSH and start investigating where is problem. I disagree. Allowing default calibration data to be used can be unnoticed by user and left her wondering why wifi works so badly. > 3) If we do rename *now* we will totally break wifi support on Nokia > N900. Then the distro should fix that when updating the linux-firmware packages. Can you provide details about the setup, what distro etc? -- Kalle Valo