From: Kalle Valo <kvalo@codeaurora.org>
To: Giedrius Statkevi?ius <giedrius.statkevicius@gmail.com>
Cc: <ath9k-devel@qca.qualcomm.com>, <linux-wireless@vger.kernel.org>,
<ath9k-devel@venema.h4ckr.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Miaoqing Pan <miaoqing@codeaurora.org>, <stable@vger.kernel.org>
Subject: Re: ath9k: bring back direction setting in ath9k_{start_stop}
Date: Wed, 07 Sep 2016 16:16:09 +0300 [thread overview]
Message-ID: <8737lbx33a.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <e61bb634860745818f8c8c99f79f71a0@euamsexm01a.eu.qualcomm.com> (Kalle Valo's message of "Wed, 7 Sep 2016 15:11:44 +0200")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> Giedrius Statkevi?ius <giedrius.statkevicius@gmail.com> wrote:
>> A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup
>> led_pin initial") that broken the WLAN status led on my laptop with
>> AR9287 after suspending and resuming.
>>
>> Steps to reproduce:
>> * Suspend (laptop)
>> * Resume (laptop)
>> * Observe that the WLAN led no longer turns ON/OFF depending on the
>> status and is always red
>>
>> Even though for my case it only needs to be set to OUT in ath9k_start
>> but for consistency bring back the IN direction setting as well.
>>
>> Cc: Miaoqing Pan <miaoqing@codeaurora.org>
>> Cc: Kalle Valo <kvalo@qca.qualcomm.com>
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
>
> Thanks, 1 patch applied to ath-next branch of ath.git:
>
> 088a60926b66 ath9k: bring back direction setting in ath9k_{start_stop}
Oops, I was supposed to apply this to ath-current branch. Please ignore
this. Luckily I didn't push yet so I can easily fix this.
--
Kalle Valo
next prev parent reply other threads:[~2016-09-07 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 17:47 [PATCH] ath9k: bring back direction setting in ath9k_{start_stop} Giedrius Statkevičius
2016-09-03 16:08 ` Giedrius Statkevičius
2016-09-03 17:35 ` Kalle Valo
2016-09-07 13:11 ` Kalle Valo
2016-09-07 13:16 ` Kalle Valo [this message]
2016-09-07 13:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737lbx33a.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=giedrius.statkevicius@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miaoqing@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).