From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932138AbcBKIzZ (ORCPT ); Thu, 11 Feb 2016 03:55:25 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:33623 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932078AbcBKIzX (ORCPT ); Thu, 11 Feb 2016 03:55:23 -0500 From: Felipe Balbi To: Oliver Neukum , Heikki Krogerus Cc: Greg KH , Mathias Nyman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 1/3] usb: USB Type-C Connector Class In-Reply-To: <1455101342.8878.5.camel@suse.com> References: <1455037283-106479-1-git-send-email-heikki.krogerus@linux.intel.com> <1455037283-106479-2-git-send-email-heikki.krogerus@linux.intel.com> <1455101342.8878.5.camel@suse.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Thu, 11 Feb 2016 10:55:16 +0200 Message-ID: <8737szsk23.fsf@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Oliver Neukum writes: > On Tue, 2016-02-09 at 19:01 +0200, Heikki Krogerus wrote: >> The purpose of this class is to provide unified interface >> for user space to get the status and basic information about >> USB Type-C Connectors in the system, control data role >> swapping, and when USB PD is available, also power role >> swapping and Altenate Modes. >>=20 >> The class will export the following interfaces for every >> USB Type-C Connector in the system to sysfs: >>=20 >> 1. connected - Connection status of the connector >> 2. alternate_mode - The current Alternate Mode >> 3. alternate_modes - Lists all Alternate Modes the connector supports > > These names are a bit problematic, as they are too similar. > How about > > current_alternate_mode > potential_alternate_modes available_ ? >> 4. partner_alt_modes - Lists partner's Alternate Modes when connected partner_alternate_modes ? (it's a file name, we can spell it out) >> 5. partner_type - Can be USB, Charger, Alt Mode or Accessory >> 6. data_role - The current data role, host or device >> 7. data_roles - Data roles supported by the connector current_data_role available_data_roles >> 8. power_role - Connector's current power role, source or sink >> 9. power_roles - Power roles supported by the connector ditto... >> 10. power_operation_mode - The current power level in use >> 11. usb_pd - yes if the connector supports USB PD. supports_usb_power_delivery ? >> 12. audio_accessory - yes if the connector supports Audio Accessory supports_audio_accessory >> 13. debug_accessory - yes if the connector supports Debug Accessory supports_debug_accessory > Doesn't this need locking? > And why wouldn't user space want to preselect a mode? isn't USB always the default mode ? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWvEx0AAoJEIaOsuA1yqREBvAP/iRNg8FmLKAgvy+UtoxDj/Yc 8Oal4vQ3jaiFE+rRJOdl7Iuc4bLTgG0qnw4r288sDfzkFSr2+xp8yQHrcBTIjR0J HkK1NH9+2NGlmev8Ba5GUpJyQE8+STWm+NqY+WiLFYN3ZYLRk6nS2lP/j4YThtAw thfK2Fu/ZYufLMo1X7O0GPGr5q0v6ecDzC4Dz8pwGnyx1R3Oht8IaxOumxXtDNnp XeapV/3CkIor0+JwSrpUxUOgrww9K5+vpMnI458WYt0sLyJiXXFdYv0DouCQ2Nfz PispZsJ2XBYRL8BIGGrWUJzmJvPyzWfNqCK77Pn3Bo+2flOFJfvd9laaYhQx6ENx mwXv4fokLqJy3lTzijJODOC8imH0BuVIIGrGII85uLVOZIM2PAYfS5riu70AGUTH 2GhjlsV579pjPIzRKqzxTHF4pxRevRcjLqRas89hKoAE1SqrQmUaZ+DCHpkzHSM9 CAeStliRQ3AFN9kimlBhn/BFTA+c2Yqo6aPCSt/Kf/l/Jb+KPpbmbPQPGqSP5MT8 ZIpjhj5uhpcy+01B7gdRbTMMAsh6B6d1qdshXrqrv0TnK6+ZZso5E2pLSoY3VvLI oN1WwY8X/JEPxr7zvFtmoIp8Ag21OwET7P3WVpnqPdG7UFhA96is180792lNR3sB 1ZIpV+vhiUj7DyIU4Vln =DLQo -----END PGP SIGNATURE----- --=-=-=--