From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751899AbbJQWMg (ORCPT ); Sat, 17 Oct 2015 18:12:36 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:33919 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbbJQWMe (ORCPT ); Sat, 17 Oct 2015 18:12:34 -0400 From: Rasmus Villemoes To: Bart Van Assche Cc: Christoph Hellwig , Hannes Reinecke , "James E.J. Bottomley" , , Subject: Re: [PATCH 1/2] scsi: move Additional Sense Codes to separate file Organization: D03 References: <20151004080217.GA22816@infradead.org> <1444037200-14684-1-git-send-email-linux@rasmusvillemoes.dk> <1444037200-14684-2-git-send-email-linux@rasmusvillemoes.dk> <56128398.8070908@sandisk.com> <87h9m4m2yq.fsf@rasmusvillemoes.dk> X-Hashcash: 1:20:151017:hare@suse.de::qQUKx5zsUgA/JOwl:000000CJv X-Hashcash: 1:20:151017:bart.vanassche@sandisk.com::PX+DHmaXj79EkT9j:000000000000000000000000000000000000ovd X-Hashcash: 1:20:151017:hch@infradead.org::13YMt2ywWJICLr10:000000000000000000000000000000000000000000001ox0 X-Hashcash: 1:20:151017:linux-scsi@vger.kernel.org::YWEGUIJ4Or82N+Ri:000000000000000000000000000000000002gv1 X-Hashcash: 1:20:151017:jbottomley@odin.com::vNOWD1z3tTBYaBuG:00000000000000000000000000000000000000000036YD X-Hashcash: 1:20:151017:linux-kernel@vger.kernel.org::ELOOIs8zYH7U652R:0000000000000000000000000000000006AQO Date: Sun, 18 Oct 2015 00:12:31 +0200 In-Reply-To: <87h9m4m2yq.fsf@rasmusvillemoes.dk> (Rasmus Villemoes's message of "Tue, 06 Oct 2015 17:27:57 +0200") Message-ID: <8737x9nnzk.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 06 2015, Rasmus Villemoes wrote: > On Mon, Oct 05 2015, Bart Van Assche wrote: > >> On 10/05/15 02:26, Rasmus Villemoes wrote: >>> - {0x041A, "Logical unit not ready, start stop unit command in " >>> - "progress"}, >>> - {0x041B, "Logical unit not ready, sanitize in progress"}, >>> - {0x041C, "Logical unit not ready, additional power use not yet " >>> - "granted"}, >> >> Please convert these multi-line strings into single line string >> constants such that users can look up these easily with grep. > > I can certainly do that, but I'd prefer to do it in a separate patch. I > really want to keep this as mechanical as possible. > >>> + >>> +SENSE_CODE(0, NULL) >> >> The above looks confusing to me. Please leave this out and add { 0, >> NULL } at the end of the additional[] array instead. > > OK, I agree that that would have been cleaner. However, the sentinel > entry is removed in 2/2 (since we loop using ARRAY_SIZE instead of > checking for the sentinel). Let me know if you want me to resend the > 1600 line monster anyway with this addressed. Should I resend, or can these be picked up as-is? I can easily send a 3/2 making the strings more greppable. Thanks, Rasmus