From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933603AbbFWQ2y (ORCPT ); Tue, 23 Jun 2015 12:28:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38184 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933489AbbFWQ2l (ORCPT ); Tue, 23 Jun 2015 12:28:41 -0400 From: Vitaly Kuznetsov To: Olaf Hering Cc: "K. Y. Srinivasan" , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, apw@canonical.com, jasowang@redhat.com Subject: Re: [PATCH V2 04/10] Drivers: hv: vmbus: add special kexec handler References: <1433460339-9346-1-git-send-email-kys@microsoft.com> <1433460376-9387-1-git-send-email-kys@microsoft.com> <1433460376-9387-4-git-send-email-kys@microsoft.com> <20150623075719.GA19219@gmail.com> Date: Tue, 23 Jun 2015 18:28:36 +0200 In-Reply-To: <20150623075719.GA19219@gmail.com> (Olaf Hering's message of "Tue, 23 Jun 2015 09:57:19 +0200") Message-ID: <87381i8k3v.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Olaf Hering writes: > On Thu, Jun 04, K. Y. Srinivasan wrote: > >> +++ b/arch/x86/kernel/cpu/mshyperv.c >> @@ -18,6 +18,9 @@ >> #include >> #include >> #include >> +#ifdef CONFIG_KEXEC >> +#include >> +#endif > > Is this #ifdef required? > No, it's not, but other parts of the same patch do (e.g. there is no kexec_in_progress without CONFIG_KEXEC). We can probably omit #ifdef here but I'm not sure it makes sense. -- Vitaly