From: "Bjørn Mork" <bjorn@mork.no>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: drbd-dev@lists.linbit.com, drbd-user@lists.linbit.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drbd: Remove fix me statements
Date: Wed, 23 Jul 2014 14:27:00 +0200 [thread overview]
Message-ID: <8738dsi7l7.fsf@nemi.mork.no> (raw)
In-Reply-To: <1406053161-5048-1-git-send-email-xerofoify@gmail.com> (Nicholas Krause's message of "Tue, 22 Jul 2014 14:19:21 -0400")
Nicholas Krause <xerofoify@gmail.com> writes:
> This removes no longer needed fix me statements
If you claim that they no longer are needed then I expect you to explain
what's changed since they were added.
> as the spinlocks
> are needed to protect against other users of the list accessing
> it when items on it are being moved off it.
Yes, that's most likely why the locking is there.
The FIXMEs on the other hand, are probably there to tell you that it
would be nice to get rid of the double locking. I don't see that
changing.
Bjørn
next prev parent reply other threads:[~2014-07-23 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 18:19 [PATCH] drbd: Remove fix me statements Nicholas Krause
2014-07-23 12:27 ` Bjørn Mork [this message]
2014-07-23 15:45 ` Nick Krause
2014-07-23 17:33 ` Bjørn Mork
2014-07-23 19:13 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738dsi7l7.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).