From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758490AbbEELty (ORCPT ); Tue, 5 May 2015 07:49:54 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:63734 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752939AbbEELte (ORCPT ); Tue, 5 May 2015 07:49:34 -0400 From: "Rafael J. Wysocki" To: Marian Marinov Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Aaron Lu Subject: Re: Patch breaks suspend Date: Tue, 05 May 2015 14:14:35 +0200 Message-ID: <8747459.CZQUHCQZpc@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.0.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5548819A.5050503@yuhu.biz> References: <55453334.9030002@yuhu.biz> <2970725.6ieOiJg9HH@vostro.rjw.lan> <5548819A.5050503@yuhu.biz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, May 05, 2015 11:38:50 AM Marian Marinov wrote: > On 05/05/2015 02:37 AM, Rafael J. Wysocki wrote: > > On Saturday, May 02, 2015 11:27:32 PM Marian Marinov wrote: > >> Hi guys, > >> I have Lenovo T520 with one SSD and one SATA drive. > >> > >> I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive. > >> Both drives have bios encryption enabled. > >> > >> I did a bisect and found that the following patch causes the issue: > >> commit 5d5132059a1f652de9dc2d62a8ff15561e648d11 > >> Author: Rafael J. Wysocki > >> Date: Sat Feb 22 00:48:31 2014 +0100 > >> > >> ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices > >> > >> Modify the SATA subsystem to add hotplug contexts to ACPI companions > >> of SATA devices and ports instead of registering special ACPI dock > >> operations using register_hotplug_dock_device(). > >> > >> That change will allow the entire code handling those special ACPI > >> dock operations to be dropped in the next commit. > >> > >> Signed-off-by: Rafael J. Wysocki > >> Reviewed-by: Aaron Lu > >> Acked-by: Tejun Heo > >> > >> Unfortunately I do not understand this part of the code and have no idea what I can do. > >> Any pointers would be very appreciated. > > Well, not right from the top of my head, but this looks really suspicious to me. > > > > Can you please file a bug entry for this at bugzilla.kernel.org (in the ACPI/BIOS > > category), assign it to me and CC Aaron? > BUG created: https://bugzilla.kernel.org/show_bug.cgi?id=97731 > > Added you and Aaron to the CC list. > > What additional info can I provide you? Would you like any debug info from the kernel it self? > Dmesg output? Let's track this one in the BZ from now on if that's not a problem. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.