linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: zhengyongjun <zhengyongjun3@huawei.com>
To: "bryan.whitehead@microchip.com" <bryan.whitehead@microchip.com>,
	"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 答复: [PATCH net-next] net: microchip: Remove set but not used variable
Date: Sat, 19 Sep 2020 03:02:39 +0000	[thread overview]
Message-ID: <874b27fec9d4494a89cbe76e4071b845@huawei.com> (raw)
In-Reply-To: <20200919023732.23656-1-zhengyongjun3@huawei.com>

This is the bad patch, please ignore it, thank you very much.

-----邮件原件-----
发件人: zhengyongjun 
发送时间: 2020年9月19日 10:38
收件人: bryan.whitehead@microchip.com; UNGLinuxDriver@microchip.com; davem@davemloft.net; kuba@kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
抄送: zhengyongjun <zhengyongjun3@huawei.com>
主题: [PATCH net-next] net: microchip: Remove set but not used variable

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend:
drivers/net/ethernet/microchip/lan743x_main.c:3041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]

`ret` is never used, so remove it.

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
 drivers/net/ethernet/microchip/lan743x_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
index de93cc6ebc1a..56a1b5928f9a 100644
--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -3053,7 +3053,7 @@ static int lan743x_pm_suspend(struct device *dev)
 	/* Host sets PME_En, put D3hot */
 	ret = pci_prepare_to_sleep(pdev);
 
-	return 0;
+	return ret;
 }
 
 static int lan743x_pm_resume(struct device *dev)
-- 
2.17.1


  reply	other threads:[~2020-09-19  3:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-19  2:37 Zheng Yongjun
2020-09-19  3:02 ` zhengyongjun [this message]
2020-09-19 21:12   ` 答复: " David Miller
2020-09-19 21:09 ` David Miller
2020-09-19  2:39 Zheng Yongjun
2020-09-19  3:08 ` 答复: " zhengyongjun
2020-09-19 21:09 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874b27fec9d4494a89cbe76e4071b845@huawei.com \
    --to=zhengyongjun3@huawei.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=bryan.whitehead@microchip.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: 答复: [PATCH net-next] net: microchip: Remove set but not used variable' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox