From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Chancel Liu <chancel.liu@nxp.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: soc-core.c: Prefer to return dai->driver->name in snd_soc_dai_name_get()
Date: Mon, 29 Jan 2024 23:46:20 +0000 [thread overview]
Message-ID: <874jevk8j8.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20240129071839.2393483-1-chancel.liu@nxp.com>
Hi Chancel
Thank you for the patch
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 516350533e73..09467c693627 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -300,12 +300,12 @@ static int snd_soc_is_matching_dai(const struct snd_soc_dai_link_component *dlc,
> const char *snd_soc_dai_name_get(struct snd_soc_dai *dai)
> {
> /* see snd_soc_is_matching_dai() */
> - if (dai->name)
> - return dai->name;
> -
> if (dai->driver->name)
> return dai->driver->name;
>
> + if (dai->name)
> + return dai->name;
> +
> if (dai->component->name)
> return dai->component->name;
>
> --
As above comment indicated, snd_soc_dai_name_get() and
snd_soc_is_matching_dai() are paired.
If you want to update snd_soc_dai_name_get(), updating
snd_soc_is_matching_dai() also is good idea.
Thank you for your help !!
Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto
prev parent reply other threads:[~2024-01-29 23:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 7:18 [PATCH] ASoC: soc-core.c: Prefer to return dai->driver->name in snd_soc_dai_name_get() Chancel Liu
2024-01-29 23:46 ` Kuninori Morimoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jevk8j8.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=broonie@kernel.org \
--cc=chancel.liu@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).