From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3671C433E0 for ; Sat, 6 Mar 2021 18:37:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 817CB65005 for ; Sat, 6 Mar 2021 18:37:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231289AbhCFSgn (ORCPT ); Sat, 6 Mar 2021 13:36:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:58924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230346AbhCFSgi (ORCPT ); Sat, 6 Mar 2021 13:36:38 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 424A464FE8; Sat, 6 Mar 2021 18:36:38 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lIbn2-0005lT-5I; Sat, 06 Mar 2021 18:36:36 +0000 Date: Sat, 06 Mar 2021 18:36:34 +0000 Message-ID: <874khorux9.wl-maz@kernel.org> From: Marc Zyngier To: Mark-PK Tsai Cc: Daniel Palmer , Thomas Gleixner , Jason Cooper , Matthias Brugger , , , , Subject: Re: [PATCH] irqchip/irq-mst: Support polarity configuration In-Reply-To: <20210305120930.14297-1-mark-pk.tsai@mediatek.com> References: <20210305120930.14297-1-mark-pk.tsai@mediatek.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: mark-pk.tsai@mediatek.com, daniel@thingy.jp, tglx@linutronix.de, jason@lakedaemon.net, matthias.bgg@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, yj.chiang@mediatek.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 05 Mar 2021 12:09:30 +0000, Mark-PK Tsai wrote: > > Support irq polarity configuration and save and restore the config > when system suspend and resume. > > Signed-off-by: Mark-PK Tsai > --- > drivers/irqchip/irq-mst-intc.c | 87 ++++++++++++++++++++++++++++++++-- > 1 file changed, 84 insertions(+), 3 deletions(-) > > diff --git a/drivers/irqchip/irq-mst-intc.c b/drivers/irqchip/irq-mst-intc.c > index 143657b0cf28..979a4d55bcb1 100644 > --- a/drivers/irqchip/irq-mst-intc.c > +++ b/drivers/irqchip/irq-mst-intc.c > @@ -13,15 +13,25 @@ > #include > #include > #include > +#include > > -#define INTC_MASK 0x0 > -#define INTC_EOI 0x20 > +#define INTC_MASK 0x0 > +#define INTC_REV_POLARITY 0x10 > +#define INTC_EOI 0x20 > + > +#ifdef CONFIG_PM_SLEEP > +static LIST_HEAD(mst_intc_list); > +#endif > > struct mst_intc_chip_data { > raw_spinlock_t lock; > unsigned int irq_start, nr_irqs; > void __iomem *base; > bool no_eoi; > +#ifdef CONFIG_PM_SLEEP > + struct list_head entry; > + u16 saved_polarity_conf[DIV_ROUND_UP(64, 16)]; Where is this 64 coming from? > +#endif > }; > > static void mst_set_irq(struct irq_data *d, u32 offset) > @@ -78,6 +88,16 @@ static void mst_intc_eoi_irq(struct irq_data *d) > irq_chip_eoi_parent(d); > } > > +static int mst_irq_chip_set_type(struct irq_data *data, unsigned int type) > +{ > + if (type == IRQ_TYPE_LEVEL_LOW) { > + mst_set_irq(data, INTC_REV_POLARITY); > + type = IRQ_TYPE_LEVEL_HIGH; > + } If you are introducing a irq_set_type callback, you need to return an error for the settings you don't handle. Thanks, M. -- Without deviation from the norm, progress is not possible.