From: Thomas Gleixner <tglx@linutronix.de>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: "open list\:TENSILICA XTENSA PORT \(xtensa\)"
<linux-xtensa@linux-xtensa.org>, Chris Zankel <chris@zankel.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] highmem: fix highmem for xtensa
Date: Mon, 16 Nov 2020 18:37:06 +0100 [thread overview]
Message-ID: <874klpyzi5.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAMo8BfLFZ_X8y1XLZnBb-VkOPMhXT4Daau9ydKAU9L_64Zap4w@mail.gmail.com>
Max,
On Mon, Nov 16 2020 at 06:47, Max Filippov wrote:
> On Fri, Nov 13, 2020 at 2:34 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>> I agree that the top down mechanics is not really intuitive, but that
>> does not justify the ifdeffery in the generic code.
>
> But then maybe xtensa did the right thing where everyone else just
> copied the not really intuitive implementation? If nobody else cares
> then maybe generic fix_to_virt/virt_to_fix can be changed for positive
> indexing?
Which requires to change 9 architectures instead of one for a feature
which is barely used nowadays and which we rather want to get rid of.
Thanks,
tglx
prev parent reply other threads:[~2020-11-16 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 12:23 [PATCH] highmem: fix highmem for xtensa Max Filippov
2020-11-13 13:40 ` Thomas Gleixner
2020-11-13 13:50 ` Max Filippov
2020-11-13 14:36 ` Thomas Gleixner
2020-11-13 16:34 ` Max Filippov
2020-11-13 22:34 ` Thomas Gleixner
2020-11-16 14:47 ` Max Filippov
2020-11-16 17:37 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874klpyzi5.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=chris@zankel.net \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).