From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B67D9C56201 for ; Mon, 9 Nov 2020 01:19:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 716C022202 for ; Mon, 9 Nov 2020 01:19:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729019AbgKIBTT (ORCPT ); Sun, 8 Nov 2020 20:19:19 -0500 Received: from mo-csw1514.securemx.jp ([210.130.202.153]:60870 "EHLO mo-csw.securemx.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727979AbgKIBTS (ORCPT ); Sun, 8 Nov 2020 20:19:18 -0500 Received: by mo-csw.securemx.jp (mx-mo-csw1514) id 0A91Itv4020729; Mon, 9 Nov 2020 10:18:55 +0900 X-Iguazu-Qid: 34trFI5eBnsfcuv5BC X-Iguazu-QSIG: v=2; s=0; t=1604884735; q=34trFI5eBnsfcuv5BC; m=fASxfKb7gMfbRWGtZyCx9j9NW3GRwWaYhWoTAptrXKU= Received: from imx12.toshiba.co.jp (imx12.toshiba.co.jp [61.202.160.132]) by relay.securemx.jp (mx-mr1513) id 0A91IrBI012852; Mon, 9 Nov 2020 10:18:53 +0900 Received: from enc02.toshiba.co.jp ([61.202.160.51]) by imx12.toshiba.co.jp with ESMTP id 0A91Ir2B008158; Mon, 9 Nov 2020 10:18:53 +0900 (JST) Received: from hop101.toshiba.co.jp ([133.199.85.107]) by enc02.toshiba.co.jp with ESMTP id 0A91Iq9M022229; Mon, 9 Nov 2020 10:18:52 +0900 From: Punit Agrawal To: Borislav Petkov Cc: Smita Koralahalli , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-edac@vger.kernel.org, linux-efi@vger.kernel.org, linux-acpi@vger.kernel.org, Tony Luck , "Rafael J . Wysocki" , Len Brown , Ard Biesheuvel , Yazen Ghannam Subject: Re: [PATCH v5] cper, apei, mce: Pass x86 CPER through the MCA handling chain References: <20201103164952.5126-1-Smita.KoralahalliChannabasappa@amd.com> <87a6vv9hch.fsf@kokedama.swc.toshiba.co.jp> <20201106120950.GC14914@zn.tnic> Date: Mon, 09 Nov 2020 10:18:46 +0900 In-Reply-To: <20201106120950.GC14914@zn.tnic> (Borislav Petkov's message of "Fri, 6 Nov 2020 13:09:50 +0100") X-TSB-HOP: ON Message-ID: <874klz9vk9.fsf@kokedama.swc.toshiba.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Borislav Petkov writes: > On Fri, Nov 06, 2020 at 02:36:46PM +0900, Punit Agrawal wrote: >> > diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper-x86.c >> > index 2531de49f56c..438ed9eff6d0 100644 >> > --- a/drivers/firmware/efi/cper-x86.c >> > +++ b/drivers/firmware/efi/cper-x86.c >> > @@ -2,6 +2,7 @@ >> > // Copyright (C) 2018, Advanced Micro Devices, Inc. >> > >> > #include >> > +#include >> >> Did you mean to include ? > > Why? Because arch_apei_report_x86_error() used in the patch is defined there. The indirect include works but pulls in additional definitions not needed by the patch. Do you prefer the more generic include? Thanks, Punit