From: Nico Schottelius <nico-linuxsetlocalversion@schottelius.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Nico Schottelius <nico-linuxsetlocalversion@schottelius.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Randy Dunlap <rdunlap@infradead.org>,
Brian Norris <briannorris@chromium.org>,
Bhaskar Chowdhury <unixbhaskar@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scripts/setlocalversion: make git describe output more reliable
Date: Mon, 21 Sep 2020 11:35:30 +0200 [thread overview]
Message-ID: <874knrqxp9.fsf@ungleich.ch> (raw)
In-Reply-To: <73cb82c5-37fd-7fa3-5778-723337934a2b@rasmusvillemoes.dk>
Hey Rasmus,
Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:
>> So I suggest you introduce something on the line of:
>>
>> ...
>> num_chars=12
>> ...
>> --abbrev=$num_chars
>
> I considered that, but it becomes quite ugly since it needs to get into
> the awk script (as a 13, though perhaps we could get awk to do the +1, I
> don't really speak awk), where we'd then need to use " instead of ' and
> then escape the $ that are to be interpreted by awk and not the shell.
No need for that, awk can read (and use) environment variables...
> So I think it's more readable with hardcoding and comments explaining
> why they are there; should anyone ever want to change 12.
... so that in practice you only need to change 13 to var+1 and 12 to $var.
Cheers,
Nico
--
Modern, affordable, Swiss Virtual Machines. Visit www.datacenterlight.ch
next prev parent reply other threads:[~2020-09-21 9:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 11:26 [PATCH] scripts/setlocalversion: make git describe output more reliable Rasmus Villemoes
2020-09-10 14:28 ` Guenter Roeck
2020-09-10 14:34 ` Masahiro Yamada
2020-09-10 19:05 ` Brian Norris
2020-09-11 8:28 ` Rasmus Villemoes
2020-09-16 14:28 ` Masahiro Yamada
2020-09-16 15:23 ` Rasmus Villemoes
2020-09-16 18:01 ` Masahiro Yamada
2020-09-16 19:31 ` Rasmus Villemoes
2020-09-17 0:48 ` Masahiro Yamada
2020-09-10 22:56 ` Bhaskar Chowdhury
2020-09-16 8:48 ` Rasmus Villemoes
2020-09-17 6:56 ` [PATCH v2] " Rasmus Villemoes
2020-09-17 12:22 ` Nico Schottelius
2020-09-17 12:58 ` Rasmus Villemoes
2020-09-21 9:35 ` Nico Schottelius [this message]
2020-09-24 17:27 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874knrqxp9.fsf@ungleich.ch \
--to=nico-linuxsetlocalversion@schottelius.org \
--cc=briannorris@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@roeck-us.net \
--cc=rdunlap@infradead.org \
--cc=unixbhaskar@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).