linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] watchdog: digicolor_wdt: remove unused variable 'ret'
@ 2019-07-11  6:40 YueHaibing
  2019-07-11  7:43 ` Baruch Siach
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-07-11  6:40 UTC (permalink / raw)
  To: wim, linux, baruch, wsa+renesas
  Cc: linux-kernel, linux-watchdog, linux-arm-kernel, YueHaibing

commit cdad26977e3f ("watchdog: digicolor_wdt: drop
warning after registering device") left this unused
variable, it can be removed.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/watchdog/digicolor_wdt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
index 33cda95..073d378 100644
--- a/drivers/watchdog/digicolor_wdt.c
+++ b/drivers/watchdog/digicolor_wdt.c
@@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct dc_wdt *wdt;
-	int ret;
 
 	wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
 	if (!wdt)
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] watchdog: digicolor_wdt: remove unused variable 'ret'
  2019-07-11  6:40 [PATCH] watchdog: digicolor_wdt: remove unused variable 'ret' YueHaibing
@ 2019-07-11  7:43 ` Baruch Siach
  0 siblings, 0 replies; 2+ messages in thread
From: Baruch Siach @ 2019-07-11  7:43 UTC (permalink / raw)
  To: YueHaibing
  Cc: wim, linux, wsa+renesas, linux-kernel, linux-watchdog, linux-arm-kernel

Hi YueHaibing,

On Thu, Jul 11 2019, YueHaibing wrote:
> commit cdad26977e3f ("watchdog: digicolor_wdt: drop
> warning after registering device") left this unused
> variable, it can be removed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Third time's a charm:

https://patchwork.kernel.org/patch/11037487/
https://patchwork.kernel.org/patch/11038317/

baruch

>  drivers/watchdog/digicolor_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
> index 33cda95..073d378 100644
> --- a/drivers/watchdog/digicolor_wdt.c
> +++ b/drivers/watchdog/digicolor_wdt.c
> @@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct dc_wdt *wdt;
> -	int ret;
>  
>  	wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
>  	if (!wdt)

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-11  7:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-11  6:40 [PATCH] watchdog: digicolor_wdt: remove unused variable 'ret' YueHaibing
2019-07-11  7:43 ` Baruch Siach

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).