From: Luis Henriques <lhenriques@suse.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>, Jiri Kosina <jkosina@suse.cz>,
"Yan\, Zheng" <zyan@redhat.com>, Sage Weil <sage@redhat.com>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org
Subject: Re: [patch 6/9] ceph: quota: Cleanup license mess
Date: Fri, 18 Jan 2019 09:42:57 +0000 [thread overview]
Message-ID: <874la6wbby.fsf@suse.com> (raw)
In-Reply-To: <20190117231501.346447710@linutronix.de> (Thomas Gleixner's message of "Fri, 18 Jan 2019 00:14:22 +0100")
Thomas Gleixner <tglx@linutronix.de> writes:
> Precise and non-ambiguous license information is important. The recently
> added aegis header file has a SPDX license identifier, which is nice, but
> at the same time it has a contradictionary license boiler plate text.
>
> SPDX-License-Identifier: GPL-2.0
>
> versus
>
> * This program is free software; you can redistribute it and/or
> * modify it under the terms of the GNU General Public License
> * as published by the Free Software Foundation; either version 2
> * of the License, or (at your option) any later version.
>
> Oh well.
>
> As the other ceph related files are licensed under the GPL v2 only, it's
> assumed that the SPDX id is correct and the boiler plate was randomly
> copied into that patch.
>
> Remove the boiler plate as it is wrong and even if correct it is redundant.
>
> Fixes: fb18a57568c2 ("ceph: quota: add initial infrastructure to support cephfs quotas")
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Luis Henriques <lhenriques@suse.com>
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: "Yan, Zheng" <zyan@redhat.com>
> Cc: Sage Weil <sage@redhat.com>
> Cc: Ilya Dryomov <idryomov@gmail.com>
> Cc: ceph-devel@vger.kernel.org
Thanks, Thomas. Fell free to add my
Acked-by: Luis Henriques <lhenriques@suse.com>
Cheers,
--
Luis
> ---
>
> P.S.: This patch is part of a larger cleanup, but independent of other
> patches and is intended to be picked up by the maintainer directly.
>
> ---
> fs/ceph/quota.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> --- a/fs/ceph/quota.c
> +++ b/fs/ceph/quota.c
> @@ -3,19 +3,6 @@
> * quota.c - CephFS quota
> *
> * Copyright (C) 2017-2018 SUSE
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License
> - * as published by the Free Software Foundation; either version 2
> - * of the License, or (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, see <http://www.gnu.org/licenses/>.
> */
>
> #include <linux/statfs.h>
>
>
>
next prev parent reply other threads:[~2019-01-18 9:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 23:14 [patch 0/9] treewide: Cleanup recently added license mess Thomas Gleixner
2019-01-17 23:14 ` [patch 1/9] block: Cleanup license notice Thomas Gleixner
2019-01-18 2:53 ` Bart Van Assche
2019-01-18 4:21 ` Jens Axboe
2019-01-17 23:14 ` [patch 2/9] crypto: aegis - Cleanup license mess Thomas Gleixner
2019-01-18 8:02 ` Ondrej Mosnáček
2019-01-25 10:47 ` Herbert Xu
2019-01-17 23:14 ` [patch 3/9] crypto: morus " Thomas Gleixner
2019-01-18 0:26 ` Fabio Estevam
2019-01-18 6:50 ` Greg Kroah-Hartman
2019-01-18 8:00 ` Ondrej Mosnáček
2019-01-17 23:14 ` [patch 4/9] crypto: aegis - Convert to SPDX license identifiers Thomas Gleixner
2019-01-18 8:01 ` Ondrej Mosnáček
2019-01-17 23:14 ` [patch 5/9] crypto: morus " Thomas Gleixner
2019-01-18 8:02 ` Ondrej Mosnáček
2019-01-17 23:14 ` [patch 6/9] ceph: quota: Cleanup license mess Thomas Gleixner
2019-01-18 9:42 ` Luis Henriques [this message]
2019-01-18 10:48 ` Ilya Dryomov
2019-01-18 10:54 ` Thomas Gleixner
2019-01-17 23:14 ` [patch 7/9] smb3: " Thomas Gleixner
2019-01-19 5:43 ` Steve French
2019-01-17 23:14 ` [patch 8/9] tools: bpftool: " Thomas Gleixner
2019-01-17 23:24 ` Jakub Kicinski
2019-01-18 0:00 ` Thomas Gleixner
2019-01-18 23:28 ` Alexei Starovoitov
2019-01-17 23:14 ` [patch 9/9] vfio/pci: " Thomas Gleixner
2019-01-23 20:05 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874la6wbby.fsf@suse.com \
--to=lhenriques@suse.com \
--cc=ceph-devel@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=idryomov@gmail.com \
--cc=jkosina@suse.cz \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@redhat.com \
--cc=tglx@linutronix.de \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).