From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B4FC43387 for ; Wed, 19 Dec 2018 18:23:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1B7E20989 for ; Wed, 19 Dec 2018 18:23:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729375AbeLSSXt (ORCPT ); Wed, 19 Dec 2018 13:23:49 -0500 Received: from mga04.intel.com ([192.55.52.120]:20237 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727232AbeLSSXt (ORCPT ); Wed, 19 Dec 2018 13:23:49 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2018 10:23:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,373,1539673200"; d="scan'208";a="131341630" Received: from fmerten-mobl.ger.corp.intel.com (HELO localhost) ([10.252.54.164]) by fmsmga001.fm.intel.com with ESMTP; 19 Dec 2018 10:23:46 -0800 From: Jani Nikula To: Shayenne Moura Cc: Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 0/7] drm: KMS cleanup remove drm_mode_object dependency In-Reply-To: <20181219164013.dr7vgfbs2w3jtix7@smtp.gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20181218133749.h4bnf5n5ljsmr2kz@smtp.gmail.com> <87woo5vf4r.fsf@intel.com> <20181219164013.dr7vgfbs2w3jtix7@smtp.gmail.com> Date: Wed, 19 Dec 2018 20:23:50 +0200 Message-ID: <874lb9pe89.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Dec 2018, Shayenne Moura wrote: > On 12/19, Jani Nikula wrote: >> On Tue, 18 Dec 2018, Shayenne Moura wrote: >> > This patch serie removes drm_mode_object dependency from >> > drm_display_mode struct. This is part of KMS cleanup. >> >> For future reference: >> >> Please use git-send-email or fix the mail threading otherwise. Patches >> 1-7 should be in reply to the cover letter. >> > Sorry about that, >> Please justify the changes in the commit messages. Your current commit >> messages focus on *what* is being done, which is fairly obvious from the >> changes themselves. Please try to describe *why* this is being >> done. That's more important for posterity. (In this case, it's basically >> explained in the FIXME comment being removed in patch 7, as well as >> Documentation/gpu/todo.rst.) >> >> BR, >> Jani. >> > Okay, thank you! But I should write on every patch why I am doing or > just on the cover letter? So this series is trivial enough that I can look the other way... ;) But in general each patch should have a justification, even if just one sentence in the commit message. The why. The commit messages get recorded in git history, but the cover letter gets lost. BR, Jani. > > Bests, > Shayenne >> >> > >> > Shayenne Moura (7): >> > drm: msm: Delete base.id prints >> > drm: Remove use of drm_mode_object >> > drm: omapdrm: Delete base.id prints >> > drm: i915: Delete base.id prints >> > drm: sti: Delete base.id prints >> > drm: meson: Delete base.id prints >> > drm: Complete remove drm_mode_object dependency >> > >> > drivers/gpu/drm/drm_crtc_helper.c | 5 ++--- >> > drivers/gpu/drm/drm_modes.c | 9 --------- >> > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- >> > drivers/gpu/drm/meson/meson_dw_hdmi.c | 9 ++++----- >> > drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 4 ++-- >> > drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c | 4 ++-- >> > drivers/gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c | 4 ++-- >> > drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 4 ++-- >> > drivers/gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c | 4 ++-- >> > drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 ++-- >> > drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c | 4 ++-- >> > drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 ++-- >> > drivers/gpu/drm/msm/edp/edp_bridge.c | 4 ++-- >> > drivers/gpu/drm/omapdrm/omap_connector.c | 4 ++-- >> > drivers/gpu/drm/omapdrm/omap_crtc.c | 4 ++-- >> > drivers/gpu/drm/sti/sti_crtc.c | 4 ++-- >> > include/drm/drm_modes.h | 10 ++++------ >> > 17 files changed, 36 insertions(+), 49 deletions(-) >> >> -- >> Jani Nikula, Intel Open Source Graphics Center -- Jani Nikula, Intel Open Source Graphics Center