From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754052AbdESMAL (ORCPT ); Fri, 19 May 2017 08:00:11 -0400 Received: from mga03.intel.com ([134.134.136.65]:59375 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752887AbdESMAH (ORCPT ); Fri, 19 May 2017 08:00:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,363,1491289200"; d="scan'208";a="859026022" From: Jani Nikula To: Colin King , Tom Cooksey , Eric Anholt , David Airlie , dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static In-Reply-To: <20170519110203.19417-1-colin.king@canonical.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170519110203.19417-1-colin.king@canonical.com> Date: Fri, 19 May 2017 15:03:31 +0300 Message-ID: <874lwhoxyk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 May 2017, Colin King wrote: > From: Colin Ian King > > structure pl111_display_funcs can be made static as it does not need to be > in global scope. Fixes sparse warning: > > "warning: symbol 'pl111_display_funcs' was not declared. Should it > be static?" > > Fixes: bed41005e6174d ("drm/pl111: Initial drm/kms driver for pl111") The patch looks good and I appreciate what you're doing, but I question the usefulness of adding Fixes: tags for trivial stuff like this. I'd prefer Fixes: was reserved for actual fixes that should be backported to any kernels that have the commit being fixed. The same applies to many other patches you've sent recently. BR, Jani. > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/pl111/pl111_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c > index 39a5c33bce7d..bd8ff82c2fd9 100644 > --- a/drivers/gpu/drm/pl111/pl111_display.c > +++ b/drivers/gpu/drm/pl111/pl111_display.c > @@ -280,7 +280,7 @@ static int pl111_display_prepare_fb(struct drm_simple_display_pipe *pipe, > return drm_fb_cma_prepare_fb(&pipe->plane, plane_state); > } > > -const struct drm_simple_display_pipe_funcs pl111_display_funcs = { > +static const struct drm_simple_display_pipe_funcs pl111_display_funcs = { > .check = pl111_display_check, > .enable = pl111_display_enable, > .disable = pl111_display_disable, -- Jani Nikula, Intel Open Source Technology Center