From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756175AbcK3BIi (ORCPT ); Tue, 29 Nov 2016 20:08:38 -0500 Received: from relmlor3.renesas.com ([210.160.252.173]:64036 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752510AbcK3BI3 (ORCPT ); Tue, 29 Nov 2016 20:08:29 -0500 X-IronPort-AV: E=Sophos;i="5.31,719,1473087600"; d="scan'";a="227298427" Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Message-ID: <874m2pbwsn.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Stephen Boyd CC: Rob Herring , Linux-ALSA , Linux-DT , Michael Turquette , Russell King , Linux-Kernel , Mark Brown , , Linux-ARM Subject: Re: [alsa-devel] [PATCH v2] clkdev: add devm_of_clk_get() In-Reply-To: <20161129210556.GC6095@codeaurora.org> References: <87ziptixv7.wl%kuninori.morimoto.gx@renesas.com> <20160707122636.GP1041@n2100.armlinux.org.uk> <8760shgfzu.wl%kuninori.morimoto.gx@renesas.com> <146794140875.73491.7115209079607438738@resonance> <871t34hlin.wl%kuninori.morimoto.gx@renesas.com> <878twndi54.wl%kuninori.morimoto.gx@renesas.com> <8737isvwc6.wl%kuninori.morimoto.gx@renesas.com> <20161123191037.GE25626@codeaurora.org> <87a8cpejn5.wl%kuninori.morimoto.gx@renesas.com> <87y409cw71.wl%kuninori.morimoto.gx@renesas.com> <20161129210556.GC6095@codeaurora.org> User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Wed, 30 Nov 2016 01:08:20 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: TY1PR01CA0062.jpnprd01.prod.outlook.com (10.167.153.150) To KL1PR0601MB1447.apcprd06.prod.outlook.com (10.169.69.25) X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1447;2:Ag7K0qT390m2fcrxOf95VPxqLqbI1UwT+f6DNo+ujq2dHHsB6X6fGQ4RGOOxc27KLVLYV1UJkPU4E3JO3veNYVvbhCkPyt/k/j8c+ofzrsD32cs040guZx/f5taw5ZcDPwmKgjepxNP1LnS/mXyrICkCyXPXbTPoqrf9W4rSnZQ=;3:seuNkYOe4POvtYswNR08I0vOF1QLhw5OhiyYmA9v471kJY1D5xDgCgJfbkP1HueROq+u8V5o6P+UoqxMgMowxga9WVufJ8hAatjAaZn/7Xjuh9Adea1VLfLX+lfGznWCXtrodz289L3waRt9RHHyScmPHTCTbj28UBkHyG07HV4= X-MS-Office365-Filtering-Correlation-Id: 5e581d77-0601-4554-2823-08d418bd60d4 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:KL1PR0601MB1447; X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1447;25:xBHp8Hg42/J3z1jqnTPdzMtsDjtlsXHEO9sqITUe2E6iiatyNArsSxsRoAYp01WzDhjaDGpMI1UX2Ub0FJX2sCGn35ia/Ri4/KPTQK4rXPTwM8g9v7mBJ6KodyNBYVTzSUBAE0oiBvcqN/N3WhhohMJKeUQgQISRe2PY56+tR9Ar95X+dfy7ElYMOB5qjQReAPZeJG41wjSu2cqbjyzgxEXNDPLle3JDSJ9RpPpDE5EqGWplAIFkkVDWLIs+nrBcCDclbFtfYj6IuiNDS2kBtd407fSXY6shyO5j13WQHagMjjhyTeA4s5F9opQW6MIuSIcuha7CZk6uS1Wa8n0Xs87ruRsRSJZP/pY5UqmKI3Ftr3tYA1U07RdvcJFQi9qh/eXcVc0jW7mxCgacoZJDOQriF2NPYf9OzpUpNb0QHguDAUiuvWD8jAMfYwtRH/pGJ8Gym38ZSALTEUKW4GfefAtFwlX3gvIGrWKIqvAIEatc2mnCBNtFYDldIa4oYAFjEL4BTBxPK53eEFR9HQhAUV6KHoWzs0yolCdfWZSMnJDfIDPo/Y7S5/d9Uzaaff6scjIDGWkB0vzDc/G9IGGkp4rnYjesW4RzGW8Xu59zA/GLOz0qJw5Ite9TPln8M4LxxwvCEw4M/f6MclUkRVprlhws2SXg5TqW3H7VP77zLWxogcnyrpQFDDdWAaBAWby8OxYUlQBxGyXatzx/KewBP8UOSapxONhjZF78yg3QxZOncBYqrNseIpJ9NlR4kKSx X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1447;31:YJs4fEJWDEmJ9RXp4atVovXnqI0V3nCGbjXbqAFFR2Mxv80MxfzXb9z4BryvYb/D3BQqValBMyjhKGXX0x2WZSURC/E0YCaEfXPqGUApwR66BUV9MNoKxWX8UHZyBzTlCC7YEUImg09Cugkn+ZOugTYjiZ0U1X1ivoilRmRXI6rDOuO2OWpgFYthhrAtvllRfRp35J/bEDTGVVtMpcEGz6/bgtIGpeoKAHWwEXJNNVIH3VrZtlkX8TugAt4Ka100Mh7TSgSIXSVrvNunihi2xRtY5PxGrqG+PAg2np6wMnLr//8JP9ZuNL/tzE4hi1CV;20:AxzM0s3dHpb9naLglQl6yx7RjWgurd5zjE7bJ6b2EIWyTHTwPa/F6fi2WdsD4IsfNMe6SimE6l2ZYfYjIHs6KICRkhVnJwECagzyceRKvlxi1WEP3VZbC8R6nIPAhSvq5RdAByRqkJKlGxOZqE83NoYqQGoxjwS29pZZ+OVcUHdreK2H1tzT0I1Od43n81/eETV6VAQPX9AFXkMwJbWOinLevGx+ojszturjTXv5a3tGmwnQj2sPL59Hwa+MEGiLdf1LXLLP19ocrXJo5R1ZdDnvXlifqLGp4MQmgtAbSl+0CLbzOuz/zs4rA6FiOFWNVa5UIoyEz0fLkfDqq+7kW422rFIKIV6xZQOpbW8MSyljaWsuyIAUj8uhZvrfG/geArN+UVEoREVGdunQoic7u85oeQCD0hRxlsSCt6JkUF9dNUf/P7ezKCPQ3TdRy9iRAGsgefTcRlLJawT7ReYMZGWZ8xkQ3Ug6oadFTc6hKzLABfDeT8igi/wBDLfuy0ho X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(6072148);SRVR:KL1PR0601MB1447;BCL:0;PCL:0;RULEID:;SRVR:KL1PR0601MB1447; X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1447;4:K33ko9oaKbhxSW4RMe38Qujhkc5o5NFTfidJ4kMzW9gguK040eOvIrVAByPp0a9TR++NxfmCfn5c5r8GE3njsRlTdBapYdui83h/tYmpwKyw3O8DDVO2Z1aeqYf7z1/iAOzWrXgkV5cyGATLmJU7Y138HNYejj/0ZKuBN5jVXDBxxrTsRgGxg/CNB5hvsO6fsyKwAFSkFCObIJdVCU0UcaBJKK7QMlK165LNeLHdF28+Qy3xphaPJB3FIKaK1P/KfSX4Z3vy0SmpgMBflLm4OIuqCCFfI2Y4aqcZw53UExRQAEhE3/7M3MerbXVAwcFZiX6LH3K36AD7IPPzUFCIpElyf1hHRIsfhTd9uVEMOjCCWzG2u5dLKRGrs46BWyS4+vkyT6/UIhDaNXJEiZq0O1vF6wc1qytYUdquA5qRR3MO+qSY63wtkTMsSPSsHp7avdRVjKPG8nGWVxqrmYUNqtw5A1FZRJvnz/J4yW6/SQqqL8J8Ezlipy4GmDvqBXLlG4G1OjxfeYFzh0NfW175eXDYnIOuYovPLiyC46WsR511XwddfieAZNjHRyEx2do/j58OjOxjCY3UO1J2tQp+Eg== X-Forefront-PRVS: 0142F22657 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(199003)(68736007)(54356999)(305945005)(81166006)(7736002)(7846002)(47776003)(69596002)(50986999)(66066001)(5660300001)(4326007)(39450400002)(36756003)(46406003)(23726003)(42186005)(81156014)(8676002)(97736004)(50466002)(6486002)(38730400001)(2906002)(3846002)(39410400001)(229853002)(101416001)(189998001)(6116002)(733004)(83506001)(6916009)(76176999)(53416004)(4001350100001)(93886004)(92566002)(2950100002)(86362001)(33646002)(110136003)(345774005)(106356001)(7416002)(105586002)(21314002)(16060500001);DIR:OUT;SFP:1102;SCL:1;SRVR:KL1PR0601MB1447;H:morimoto-PC.renesas.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;KL1PR0601MB1447;23:3D/C7pm9OEKDY1J4fTSnFloge/rFOilK2TXhhVk?= =?us-ascii?Q?CN7Da9OkU77OKynmCnhKLmArzdF/08UmDU4E/kPjDNtLHjA/1UvCrtwBCagW?= =?us-ascii?Q?dBaUcGVdV88hK4OK4KX5jZeFvYclGB4fKWmuy34PPhGFJAsZ3SXqMUWdfl4A?= =?us-ascii?Q?7gDO4i4CnhUYy/CcAIsrOaUDYZ6BFu/OxMrCRJfqllfg1dgQ9tY2kMUwVft/?= =?us-ascii?Q?AXrcQ/aZyFpNfKfR7L4ghBdl7m02WKXHbYZ5GJeScafooF3ZR1yCSa5KnFt1?= =?us-ascii?Q?cV491kIao0HXiAP8jwYDy1x25T/zzQkHd7qeGeRsrxcXYhcFIOuMLnTOVFgG?= =?us-ascii?Q?5mv/wkz9bxjbU10bx7iPRTIvXo6oW2VTrFVaagztmzB+bZQ7SGiB9A6RhReD?= =?us-ascii?Q?0O500x0MaBA42zrmhqhbBNDeHSz+safzQkWfdPuyIIyioiBF4jsiwlvhkEgF?= =?us-ascii?Q?nCeQxBdL5V3Jd+y/d925fom+PXHk8kXh3eAaNu+41ffpu04A989Os5Z8Ko8k?= =?us-ascii?Q?L1WJyb3t7dIx8nDYc4ci83xtKhrYn7Umq/bw46iElzSoQV+LktS7QAf5Ajad?= =?us-ascii?Q?ukPCR7QZuls4ele9Un3TtwSX4HK3SXR55vC0/p6kBLRRG3qhTNr2m2s0qPnq?= =?us-ascii?Q?Xz3awDlMBrgPv4IIhfKzRyzbnauUYKqdsFx6A7DG1zQj2RChaXjEPV0PQI3q?= =?us-ascii?Q?fBF3ThNDTU9+T7fzauAYjMHSBC0vlgI8aYqaSL3CfI3ve3aDr4Svm2hl2cr3?= =?us-ascii?Q?qrpdkK/fp5uDvoWoDKWWO/Ipcg86mx6YmQTCBmBc0iAmcVX+2m69vBfRRihM?= =?us-ascii?Q?3HIZ1TgXXfnemD6jvZHlrHHjw1FqSZOulu5RVTi3OPAQXwraV30dSQtTV3Hj?= =?us-ascii?Q?dV+ZF8PwqCioj0w2b7o96/32XcK7s9kmNxlGhRL9mpJA8OZgcxX6iXQxLVLG?= =?us-ascii?Q?aspylfdYpiBwXZF71ZgXtOao8xVJXjqZ4FkPsCyFsF/ij4D6wEbPFrZZmWaN?= =?us-ascii?Q?AtUC8y+ZiDzck8xsjVfUpOyQrU1RD1bXa9sWRC8m5b1YmQwJ1V4YBJvgi5BL?= =?us-ascii?Q?8a0Y5pWGAuHcBpqXSyVyNpIQfRiW96/oYhEcMA2pm9WRIQZqtX1LSHEENfJE?= =?us-ascii?Q?+yRNrOFsiC/BLdlcgU7vfWg0zVFcSeYsv+lgfkJZSpnaSdWwBVtzny1goEiN?= =?us-ascii?Q?Yck6/YSdAbh5mHoXUvyGcSgeR8PVqwUfEipPpmSGqGMjd3rHtEHX+ShtDZS2?= =?us-ascii?Q?9yFIzdbS2MpphVljE/4wRJNX19UEBk0VUAUoyuNfAJ9zB93Gt7zuzRb034kX?= =?us-ascii?Q?VjqqFkrOOVmlWl/kbr3T8K94=3D?= X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1447;6:XznvuglsD0WQQ5eFjPP0VH+Tdmokd/5IqCiKPr5izUicdg7wBZdLAzSYNrvXaqtRKpQiiEzWpU8e0J8irqObEvhEBvvlR8Sk6PggPXXmVHJ1V+yuGenHn6qMDHQmM74X8amK90FXi92daQnCmBSbhFBRMWA2/v+d8PZNHHt+jU7DGy0Mk2BDNlV8Pl+6RJiVWV82J9K7CcSw3VfHI2mrgUg4DQY19MJ3AGJ/FShx0lD9UfsvgRc2kubiZ9Fv08QHTgn7Tiqwe2MkAFqvn2pBbLwl0BqUjkBseGKFz3lN91skNjbQxupiNM1YD0jp3Vz20GLz9EMk3DKvgXPh8Ibr34Zrvlf8Lodr/RXq0Y2WoknpF4/dWZF58g5l6ZB6lvAf;5:W4JTXQ39RqFXFgVwrAVjHsiYe0CHJ8xaB3BfFMkIE6kc0V2MosetqoNqIA2x+zgNotZQvdFkP6NguZKDg029pgFnZaSXqOxknbQPbw/qIZ04PcpRBudjRS2zmZBO0ndH/GRHIcTnOGFTnHroLANHRfhCss5h5bUsDcGsK02Otp0=;24:QE+JhqSJLxg0CIuyI48VvLtHI3m1KvyFhxoxk9j59Mgmw+sOdZ8eiPqWMsrce2iOHjMOZdW5T55nVhBwnE6L0Cds+EKkfonKQVvftS/coE4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1447;7:kmI81U1fyTVO78+YXJG09QkVeA7PmIMDD5WtxI2QadnSW0khn6oFSqyyf2LsAuKH8wRiEuV9DMeHqyBSmI7r7XOJma0RcgXOfsv0ckUPwPVeyjLAkMrIzOze5b3HPWNyHqplltXMjlSnuWlYxf7lbsk53ZdkENqDl1Mmrge2kn59sJ/XeLxBonXRp8WsF5QjAzckF3nprPZxX7Bn42u6xMiPAbgtZRNCA2SkAUjKa/PS8M8o4HK6dgMEYC6Uy1l/q7mPlHisfmNEXVR+XFdnIntNFwkNDA4OOpvh4aV8vyCMc0cvCKepXgkmDv8wV+X1vJuNlJlAAdI17iVZm50oc884RBQfuZVwAZEuOl5JxWI=;20:1kSnVXomgsQJT3F3+ubHOi0Rv+buMJXGLazQB+2t7zIaClMQqXGKqh/e5ct9fDlpzXllAzIBg/pvbCHvr82S5h8rLdsMG9Vpnr39c4lHhUV+sSvqFZK6hEYA22w5uw31mHJHXjyZIzC/mHK63wvalzLlozMpKepIUOOZS4YzJ7Y= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2016 01:08:20.7895 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB1447 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen Thank you for your feedback. > > > > sound_soc { > > > > clocks = <&xxx>, <&xxx>; > > > > clock-names = "cpu", "codec"; > > > > ... > > > > cpu { > > > > ... > > > > }; > > > > codec { > > > > ... > > > > }; > > > > }; (snip) > The problem is that it encourages the use of of_clk_get() when > clk_get() is more desirable. Ideally of_clk_get() is never used > when a device exists. In this case, it seems like we need to > support it though, hence the suggestion of having a > devm_get_clk_from_child() API, that explicitly reads as "get a > clock from a child node of this device". The distinction is > important, because of_clk_get() should rarely be used. I understand your point, but I think devm_get_clk_from_child() needs new DT setings, and it can't keep compatibility, or it makes driver complex. I think it is nice to have. but, I want to keep current style. Thus, I will try to use current of_clk_get() as-is, and call clk_free() somehow in this driver.