From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Zhang Yi <yi.zhang@huawei.com>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH v2] f2fs: avoid attaching SB_ACTIVE flag during mount
Date: Sat, 4 Sep 2021 11:06:29 +0800 [thread overview]
Message-ID: <8756a722-3363-9033-4a5f-047e28af645c@kernel.org> (raw)
In-Reply-To: <YTK7JDnpc6+LNqsl@google.com>
On 2021/9/4 8:17, Jaegeuk Kim wrote:
> I remember this gave a regression before?
I have removed changes which bothers checkpoint disabling path, how
about testing this in dev-test branch for a while?
BTW, any plan to porting checkpoint disabling testcases from android
into xfstest suit?
Thanks,
>
> On 09/01, Chao Yu wrote:
>> Quoted from [1]
>>
>> "I do remember that I've added this code back then because otherwise
>> orphan cleanup was losing updates to quota files. But you're right
>> that now I don't see how that could be happening and it would be nice
>> if we could get rid of this hack"
>>
>> [1] https://lore.kernel.org/linux-ext4/99cce8ca-e4a0-7301-840f-2ace67c551f3@huawei.com/T/#m04990cfbc4f44592421736b504afcc346b2a7c00
>>
>> Related fix in ext4 by
>> commit 72ffb49a7b62 ("ext4: do not set SB_ACTIVE in ext4_orphan_cleanup()").
>>
>> f2fs has the same hack implementation in
>> - f2fs_recover_orphan_inodes()
>> - f2fs_recover_fsync_data()
>>
>> Let's get rid of this hack as well in f2fs.
>>
>> Cc: Zhang Yi <yi.zhang@huawei.com>
>> Cc: Jan Kara <jack@suse.cz>
>> Acked-by: Jan Kara <jack@suse.cz>
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>> v2:
>> - don't bother checkpoint disabling path
>> fs/f2fs/checkpoint.c | 3 ---
>> fs/f2fs/recovery.c | 8 ++------
>> 2 files changed, 2 insertions(+), 9 deletions(-)
>>
>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
>> index 83e9bc0f91ff..7d8803a4cbc2 100644
>> --- a/fs/f2fs/checkpoint.c
>> +++ b/fs/f2fs/checkpoint.c
>> @@ -705,9 +705,6 @@ int f2fs_recover_orphan_inodes(struct f2fs_sb_info *sbi)
>> }
>>
>> #ifdef CONFIG_QUOTA
>> - /* Needed for iput() to work correctly and not trash data */
>> - sbi->sb->s_flags |= SB_ACTIVE;
>> -
>> /*
>> * Turn on quotas which were not enabled for read-only mounts if
>> * filesystem has quota feature, so that they are updated correctly.
>> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
>> index 04655511d7f5..706ddb3c95c0 100644
>> --- a/fs/f2fs/recovery.c
>> +++ b/fs/f2fs/recovery.c
>> @@ -787,8 +787,6 @@ int f2fs_recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only)
>> }
>>
>> #ifdef CONFIG_QUOTA
>> - /* Needed for iput() to work correctly and not trash data */
>> - sbi->sb->s_flags |= SB_ACTIVE;
>> /* Turn on quotas so that they are updated correctly */
>> quota_enabled = f2fs_enable_quota_files(sbi, s_flags & SB_RDONLY);
>> #endif
>> @@ -816,10 +814,8 @@ int f2fs_recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only)
>> err = recover_data(sbi, &inode_list, &tmp_inode_list, &dir_list);
>> if (!err)
>> f2fs_bug_on(sbi, !list_empty(&inode_list));
>> - else {
>> - /* restore s_flags to let iput() trash data */
>> - sbi->sb->s_flags = s_flags;
>> - }
>> + else
>> + f2fs_bug_on(sbi, sbi->sb->s_flags & SB_ACTIVE);
>> skip:
>> fix_curseg_write_pointer = !check_only || list_empty(&inode_list);
>>
>> --
>> 2.32.0
next prev parent reply other threads:[~2021-09-04 3:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 8:06 [PATCH v2] f2fs: avoid attaching SB_ACTIVE flag during mount Chao Yu
2021-09-04 0:17 ` Jaegeuk Kim
2021-09-04 3:06 ` Chao Yu [this message]
2021-09-10 22:06 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8756a722-3363-9033-4a5f-047e28af645c@kernel.org \
--to=chao@kernel.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).