From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A6CCC433E3 for ; Mon, 10 Aug 2020 12:25:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7943320709 for ; Mon, 10 Aug 2020 12:25:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726756AbgHJMZc (ORCPT ); Mon, 10 Aug 2020 08:25:32 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:45738 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726518AbgHJMZb (ORCPT ); Mon, 10 Aug 2020 08:25:31 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: gtucker) with ESMTPSA id 0840B2935C0 Subject: Re: [PATCH 1/3] ARM: exynos: clear L220_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val To: Russell King - ARM Linux admin , Krzysztof Kozlowski Cc: Kukjin Kim , Rob Herring , kernel@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <860eb8a1eed879e55daf960c96acdac514cbda93.1596028601.git.guillaume.tucker@collabora.com> <20200803133439.GB476@kozik-lap> <20200803142244.GO1551@shell.armlinux.org.uk> From: Guillaume Tucker Message-ID: <875ad268-d65c-673e-6f5a-76d48c24f478@collabora.com> Date: Mon, 10 Aug 2020 13:25:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200803142244.GO1551@shell.armlinux.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/2020 15:22, Russell King - ARM Linux admin wrote: > On Mon, Aug 03, 2020 at 03:34:39PM +0200, Krzysztof Kozlowski wrote: >> On Wed, Jul 29, 2020 at 02:47:31PM +0100, Guillaume Tucker wrote: >>> The L220_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable >>> sequence. There is no need to set it in the default register value, >>> this was done before support for it was implemented in the code. It >>> is not set in the hardware initial value either. >>> >>> Clean this up by removing this flag from the default l2c_aux_val, and >>> add it to the l2c_aux_mask to print an alert message if it was already >>> set before the kernel initialisation. >>> >>> Signed-off-by: Guillaume Tucker >>> --- >>> arch/arm/mach-exynos/exynos.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Makes sense. I'll take it after the merge window. > > Yes, because platforms actually have no control over this bit through > these values. > > Please fix the description to use the right define, it's > L310_AUX_CTRL_NS_LOCKDOWN not L220_AUX_CTRL_NS_LOCKDOWN. Thanks, fixed in v2. Guilaume