From: Kalle Valo <kvalo@kernel.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Johannes Berg <johannes.berg@intel.com>,
Gregory Greenman <gregory.greenman@intel.com>,
Luca Coelho <luciano.coelho@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: mainline build failure due to c1918196427b ("iwlwifi: pcie: simplify MSI-X cause mapping")
Date: Fri, 27 May 2022 12:20:55 +0300 [thread overview]
Message-ID: <875ylrqqko.fsf@kernel.org> (raw)
In-Reply-To: <YpCWIlVFd7JDPfT+@debian> (Sudip Mukherjee's message of "Fri, 27 May 2022 10:13:06 +0100")
Sudip Mukherjee <sudipm.mukherjee@gmail.com> writes:
> The latest mainline kernel branch fails to build for mips allmodconfig
> with the error:
>
> drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1093: error: "CAUSE" redefined [-Werror]
> 1093 | #define CAUSE(reg, mask) \
> |
> In file included from ./arch/mips/include/asm/ptrace.h:19,
> from ./include/linux/sched/signal.h:14,
> from ./include/linux/rcuwait.h:6,
> from ./include/linux/percpu-rwsem.h:7,
> from ./include/linux/fs.h:33,
> from ./arch/mips/include/asm/elf.h:12,
> from ./include/linux/elf.h:6,
> from ./include/linux/module.h:19,
> from ./include/linux/device/driver.h:21,
> from ./include/linux/device.h:32,
> from ./include/linux/pci.h:37,
> from drivers/net/wireless/intel/iwlwifi/pcie/trans.c:7:
> ./arch/mips/include/uapi/asm/ptrace.h:18: note: this is the location of the previous definition
> 18 | #define CAUSE 65
>
> git bisect pointed to c1918196427b ("iwlwifi: pcie: simplify MSI-X cause mapping")
>
> And, reverting it on top of mainline branch has fixed the build failure.
We have a fix:
iwlwifi: pcie: rename CAUSE macro
https://patchwork.kernel.org/project/linux-wireless/patch/20220523220300.682be2029361.I283200b18da589a975a284073dca8ed001ee107a@changeid/
It's marked as accepted but I don't know where it's applied to, Gregory?
This is failing the build, should Linus apply the fix directly to his
tree?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-05-27 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 9:13 mainline build failure due to c1918196427b ("iwlwifi: pcie: simplify MSI-X cause mapping") Sudip Mukherjee
2022-05-27 9:20 ` Kalle Valo [this message]
2022-05-27 9:23 ` Johannes Berg
2022-05-28 0:24 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ylrqqko.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=davem@davemloft.net \
--cc=gregory.greenman@intel.com \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).