From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CC71C43460 for ; Wed, 7 Apr 2021 14:03:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E49261165 for ; Wed, 7 Apr 2021 14:03:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352750AbhDGODM (ORCPT ); Wed, 7 Apr 2021 10:03:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57065 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352742AbhDGODK (ORCPT ); Wed, 7 Apr 2021 10:03:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617804180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Uu7DUKi3aMdx30NPxijI78spi2F+sW6pd08YQfEqN7g=; b=jNU9sqeveZMj2pGlqMQfeNHlmZuXWU/1I1cuB4e6Fi+A//bM0k52Sd1Ful7/Z6snpF4vOx Hdl51QU0gcaoRls6vBLha6xDOgQegDpYXfKbUFQesqWQXKNo+ods20/ZeTYpf0jkjYe5eD oraTyLG2/42sf+tQ576XSQy8ZX1RXao= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-99-F3ZBWxZaPTqcENHMRoDX2A-1; Wed, 07 Apr 2021 10:02:58 -0400 X-MC-Unique: F3ZBWxZaPTqcENHMRoDX2A-1 Received: by mail-ej1-f69.google.com with SMTP id n21so3374367ejl.11 for ; Wed, 07 Apr 2021 07:02:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=Uu7DUKi3aMdx30NPxijI78spi2F+sW6pd08YQfEqN7g=; b=ZWvNm4kb8JV9FSm3fKTgtDmQGluRXw4X+slNYHqkayuhxh00XDT2+iRr6pimWKmM/j AYOVHXZuyA2XxItlnp75UupBXmmvWi4LreympACb7501SvX27x+pHTEUCqFC1qvHFsEg q0vLVS/Y1d2YzfoEjdWcA2Cto+13PAr4b3cjFRM+B73K+ipeMFpVKofBQiyFh6WLEcYc 86zRdJJLnK6KiOEu9cxodE+UNhnBh+F1QlXjmO3VbQKIE1LS4LG7t629iOIbg/JyU/56 84mkonlxF2ApBtodPIQMDGPjrNmveujrPOuUGSxGwnihyvJhLJcM5ojkgQn/rbNS2wFV YZbA== X-Gm-Message-State: AOAM53334tPkmpOPmGkBsYIWCyVdsxzJGo0iD2PTHdOs+FlKTUII85/x rJZuVSf1vbFbAkPl74kbH9+58YdOqHv20CFH9FjlXqZQGodNwLve/wE9FclTZka8wXk6/e9CHKw SpzzpWZW2RoNlcJTNlkOaVm19 X-Received: by 2002:a05:6402:42d1:: with SMTP id i17mr4441856edc.131.1617804177706; Wed, 07 Apr 2021 07:02:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRY/y/lnspEMRzFi+bpSAp/LmL7KtYGcLjTCU76MWEezzicC4MAIKqO/OW+TvYrU+991QDMw== X-Received: by 2002:a05:6402:42d1:: with SMTP id i17mr4441825edc.131.1617804177514; Wed, 07 Apr 2021 07:02:57 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id x17sm12637723ejd.68.2021.04.07.07.02.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 07:02:57 -0700 (PDT) From: Vitaly Kuznetsov To: Wei Liu Cc: Nuno Das Neves , linux-hyperv@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, mikelley@microsoft.com, viremana@linux.microsoft.com, sunilmut@microsoft.com, wei.liu@kernel.org, ligrassi@microsoft.com, kys@microsoft.com Subject: Re: [RFC PATCH 04/18] virt/mshv: request version ioctl In-Reply-To: <20210407134302.ng6n4el2km7sujfp@liuwe-devbox-debian-v2> References: <1605918637-12192-1-git-send-email-nunodasneves@linux.microsoft.com> <1605918637-12192-5-git-send-email-nunodasneves@linux.microsoft.com> <87y2fxmlmb.fsf@vitty.brq.redhat.com> <194e0dad-495e-ae94-3f51-d2c95da52139@linux.microsoft.com> <87eeguc61d.fsf@vitty.brq.redhat.com> <87eefmczo2.fsf@vitty.brq.redhat.com> <20210407134302.ng6n4el2km7sujfp@liuwe-devbox-debian-v2> Date: Wed, 07 Apr 2021 16:02:56 +0200 Message-ID: <875z0ychv3.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wei Liu writes: > On Wed, Apr 07, 2021 at 09:38:21AM +0200, Vitaly Kuznetsov wrote: > >> One more though: it is probably a good idea to introduce selftests for >> /dev/mshv (similar to KVM's selftests in >> /tools/testing/selftests/kvm). Selftests don't really need a stable ABI >> as they live in the same linux.git and can be updated in the same patch >> series which changes /dev/mshv behavior. Selftests are very useful for >> checking there are no regressions, especially in the situation when >> there's no publicly available userspace for /dev/mshv. > > I think this can wait until we merge the first implementation in tree. > There are still a lot of moving parts. Our (currently limited) internal > test cases need more cleaning up before they are ready. I certainly > don't want to distract Nuno from getting the foundation right. > I'm absolutely fine with this approach, selftests are a nice add-on, not a requirement for the initial implementation. Also, to make them more useful to mere mortals, a doc on how to run Linux as root Hyper-V partition would come handy) -- Vitaly