From: Daniel Axtens <dja@axtens.net>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linuxppc-dev@lists.ozlabs.org, kasan-dev@googlegroups.com,
aneesh.kumar@linux.ibm.com, bsingharora@gmail.com
Subject: Re: [PATCH v10 6/6] powerpc: Book3S 64-bit outline-only KASAN support
Date: Wed, 03 Feb 2021 23:53:17 +1100 [thread overview]
Message-ID: <875z39wbwi.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <4b790789-052f-76de-a289-726517026efd@csgroup.eu>
Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Le 03/02/2021 à 12:59, Daniel Axtens a écrit :
>> Implement a limited form of KASAN for Book3S 64-bit machines running under
>> the Radix MMU, supporting only outline mode.
>>
>
>> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
>> index a66f435dabbf..9a6fd603f0e7 100644
>> --- a/arch/powerpc/kernel/process.c
>> +++ b/arch/powerpc/kernel/process.c
>> @@ -2157,8 +2157,8 @@ void show_stack(struct task_struct *tsk, unsigned long *stack,
>> break;
>>
>> stack = (unsigned long *) sp;
>> - newsp = stack[0];
>> - ip = stack[STACK_FRAME_LR_SAVE];
>> + newsp = READ_ONCE_NOCHECK(stack[0]);
>> + ip = READ_ONCE_NOCHECK(stack[STACK_FRAME_LR_SAVE]);
>> if (!firstframe || ip != lr) {
>> printk("%s["REG"] ["REG"] %pS",
>> loglvl, sp, ip, (void *)ip);
>> @@ -2176,17 +2176,19 @@ void show_stack(struct task_struct *tsk, unsigned long *stack,
>> * See if this is an exception frame.
>> * We look for the "regshere" marker in the current frame.
>> */
>> - if (validate_sp(sp, tsk, STACK_INT_FRAME_SIZE)
>> - && stack[STACK_FRAME_MARKER] == STACK_FRAME_REGS_MARKER) {
>> + if (validate_sp(sp, tsk, STACK_INT_FRAME_SIZE) &&
>> + (READ_ONCE_NOCHECK(stack[STACK_FRAME_MARKER]) ==
>> + STACK_FRAME_REGS_MARKER)) {
>> struct pt_regs *regs = (struct pt_regs *)
>> (sp + STACK_FRAME_OVERHEAD);
>>
>> - lr = regs->link;
>> + lr = READ_ONCE_NOCHECK(regs->link);
>> printk("%s--- interrupt: %lx at %pS\n",
>> - loglvl, regs->trap, (void *)regs->nip);
>> + loglvl, READ_ONCE_NOCHECK(regs->trap),
>> + (void *)READ_ONCE_NOCHECK(regs->nip));
>> __show_regs(regs);
>> printk("%s--- interrupt: %lx\n",
>> - loglvl, regs->trap);
>> + loglvl, READ_ONCE_NOCHECK(regs->trap));
>>
>> firstframe = 1;
>> }
>
>
> The above changes look like a bug fix not directly related to KASAN. Should be split out in another
> patch I think.
That code corresponds to the following part of the patch description:
| - Make our stack-walking code KASAN-safe by using READ_ONCE_NOCHECK -
| generic code, arm64, s390 and x86 all do this for similar sorts of
| reasons: when unwinding a stack, we might touch memory that KASAN has
| marked as being out-of-bounds. In our case we often get this when
| checking for an exception frame because we're checking an arbitrary
| offset into the stack frame.
|
| See commit 20955746320e ("s390/kasan: avoid false positives during stack
| unwind"), commit bcaf669b4bdb ("arm64: disable kasan when accessing
| frame->fp in unwind_frame"), commit 91e08ab0c851 ("x86/dumpstack:
| Prevent KASAN false positive warnings") and commit 6e22c8366416
| ("tracing, kasan: Silence Kasan warning in check_stack of stack_tracer")
include/linux/compiler.h describes it as follows:
/*
* Use READ_ONCE_NOCHECK() instead of READ_ONCE() if you need
* to hide memory access from KASAN.
*/
So I think it is sufficently connected with KASAN to be in this patch.
Kind regards,
Daniel
>
> Christophe
prev parent reply other threads:[~2021-02-03 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 11:59 [PATCH v10 0/6] KASAN for powerpc64 radix Daniel Axtens
2021-02-03 11:59 ` [PATCH v10 1/6] kasan: allow an architecture to disable inline instrumentation Daniel Axtens
2021-02-03 11:59 ` [PATCH v10 2/6] kasan: allow architectures to provide an outline readiness check Daniel Axtens
2021-02-03 11:59 ` [PATCH v10 3/6] kasan: define and use MAX_PTRS_PER_* for early shadow tables Daniel Axtens
2021-02-03 11:59 ` [PATCH v10 4/6] kasan: Document support on 32-bit powerpc Daniel Axtens
2021-02-03 11:59 ` [PATCH v10 5/6] powerpc/mm/kasan: rename kasan_init_32.c to init_32.c Daniel Axtens
2021-02-03 11:59 ` [PATCH v10 6/6] powerpc: Book3S 64-bit outline-only KASAN support Daniel Axtens
2021-02-03 12:45 ` Christophe Leroy
2021-02-03 12:53 ` Daniel Axtens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z39wbwi.fsf@dja-thinkpad.axtens.net \
--to=dja@axtens.net \
--cc=aneesh.kumar@linux.ibm.com \
--cc=bsingharora@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).