From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BAE7C433DF for ; Sat, 10 Oct 2020 10:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F247F21655 for ; Sat, 10 Oct 2020 10:04:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602324255; bh=HK2UVZL/bud/UoKDd8CbVzGpfM7+8L8B716hD9X9sPM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=IUMOeh1zlu2VjBz0ynllWrrIx3N5XmTweWo+S+mkfIegwraKGMP5dXPVgHr8eBFbu QgclmziEtslHpvoitRzG7xapEw4t3YxbN890ehKipkx0rbS954XYOdasYuBExaD19I vX/iixKV8YHsdKScZzKDaDg0/lzJKOKB9LyqN/Oo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728489AbgJJKDK (ORCPT ); Sat, 10 Oct 2020 06:03:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:58472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728290AbgJJJyS (ORCPT ); Sat, 10 Oct 2020 05:54:18 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E17921734; Sat, 10 Oct 2020 09:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602322940; bh=HK2UVZL/bud/UoKDd8CbVzGpfM7+8L8B716hD9X9sPM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e1UkuDvIlubAyhzYFlICCO5p1EGPcTKKIYycAUG6k/KiunsCLvHW12c8q8AsKcgDS kwT95QdMLcIBNXykxk2ZJvcbmiF1IK2eyReLpq69KLeHaAPMNKIHIz6POPAh8tEgrb s6W+Koiy6fjdcD1aZyDuTUtxRHuQcR+ae/8ijlpg= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRBOM-001GOw-40; Sat, 10 Oct 2020 10:42:18 +0100 Date: Sat, 10 Oct 2020 10:42:16 +0100 Message-ID: <875z7ipgcn.wl-maz@kernel.org> From: Marc Zyngier To: Thomas Gleixner Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thierry Reding , Jonathan Hunter , Dmitry Osipenko , Sowjanya Komatineni , Venkat Reddy Talla , kernel-team@android.com Subject: Re: [PATCH v3 1/4] genirq/irqdomain: Allow partial trimming of irq_data hierarchy In-Reply-To: <875z7kwila.fsf@nanos.tec.linutronix.de> References: <20201007124544.1397322-1-maz@kernel.org> <20201007124544.1397322-2-maz@kernel.org> <87d01t2c90.fsf@nanos.tec.linutronix.de> <9341eb039193d630d8a3f7bac920a76c@kernel.org> <875z7kwila.fsf@nanos.tec.linutronix.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: tglx@linutronix.de, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, thierry.reding@gmail.com, jonathanh@nvidia.com, digetx@gmail.com, skomatineni@nvidia.com, vreddytalla@nvidia.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 08 Oct 2020 21:47:29 +0100, Thomas Gleixner wrote: > > On Thu, Oct 08 2020 at 14:06, Marc Zyngier wrote: > > On 2020-10-08 12:22, Thomas Gleixner wrote: > > Here's what I have now, with the pmc driver calling > > irq_domain_disconnect_hierarchy() at the right spots. > > > > static int irq_domain_alloc_irq_data(struct irq_domain *domain, > > @@ -1362,11 +1442,16 @@ int __irq_domain_alloc_irqs(struct irq_domain > > *domain, int irq_base, > > mutex_unlock(&irq_domain_mutex); > > goto out_free_irq_data; > > } > > - for (i = 0; i < nr_irqs; i++) > > + for (i = 0; i < nr_irqs; i++) { > > + ret = irq_domain_trim_hierarchy(virq + i); > > + if (ret) > > + break; > > irq_domain_insert_irq(virq + i); > > You can't do that in one go because in case of an error you leak the > already inserted irqs. You need two loops. > > for (i = 0; i < nr_irqs; i++) { > ret = irq_domain_trim_hierarchy(virq + i); > if (ret) { > mutex_unlock(&irq_domain_mutex); > goto out_free_irq_data; > } > > for (i = 0; i < nr_irqs; i++) > irq_domain_insert_irq(virq + i); > > mutex_unlock(&irq_domain_mutex); > return virq; Of course you are right. I'll fold that in. Thanks, M. -- Without deviation from the norm, progress is not possible.