linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Xianting Tian <tian.xianting@h3c.com>,
	john.stultz@linaro.org, sboyd@kernel.org
Cc: linux-kernel@vger.kernel.org, tian.xianting@h3c.com
Subject: Re: [PATCH] timers: use set_current_state macro
Date: Wed, 13 May 2020 23:22:02 +0200	[thread overview]
Message-ID: <875zcz1qf9.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200508020222.15791-1-tian.xianting@h3c.com>

Xianting,

Xianting Tian <tian.xianting@h3c.com> writes:

thanks for your patch.

Can you please fix your mail client to have proper mail headers? It
provides:

  Content-Type: text/plain
  Content-Transfer-Encoding: quoted-printable

but it fails to provide the charset information. That causes the footer
to become unreadable garbage not only in my mail reader. See:

  https://lore.kernel.org/lkml/20200508020222.15791-1-tian.xianting@h3c.com/

What's worse is that is causes my patch handling scripts to decode the
mail body correctly. And I'm not really inclined to figure out how to
handle this case.

> --- a/kernel/time/timer.c
> +++ b/kernel/time/timer.c
> @@ -1885,7 +1885,7 @@ signed long __sched schedule_timeout(signed long timeout)
>                         printk(KERN_ERR "schedule_timeout: wrong timeout "
>                                 "value %lx\n", timeout);
>                         dump_stack();
> -                       current->state = TASK_RUNNING;
> +                       set_current_state(TASK_RUNNING);

That's not the same and adds a barrier which is not needed.

Not a big problem in that particular error handling code path, but in
general you really have to look whether your replacement is resulting in
the same code.

If not then you need to make an argument in the changelog why you are
replacing existing code with something which is not fully equivalent.

For this particular case, please check the implementation and read the
documentation of set_current_state() in include/linux/sched.h.

> -------------------------------------------------------------------------------------------------------------------------------------
> ±¾Óʼþ¼°Æ丽¼þº¬ÓÐлªÈý¼¯Íŵı£ÃÜÐÅÏ¢£¬½öÏÞÓÚ·¢Ë͸øÉÏÃæµØÖ·ÖÐÁгö
> µÄ¸öÈË»òȺ×é¡£½ûÖ¹ÈκÎÆäËûÈËÒÔÈκÎÐÎʽʹÓ㨰üÀ¨µ«²»ÏÞÓÚÈ«²¿»ò²¿·ÖµØй¶¡¢¸´ÖÆ¡¢
> »òÉ¢·¢£©±¾ÓʼþÖеÄÐÅÏ¢¡£Èç¹ûÄú´íÊÕÁ˱¾Óʼþ£¬ÇëÄúÁ¢¼´µç»°»òÓʼþ֪ͨ·¢¼þÈ˲¢É¾³ý±¾
> Óʼþ£¡

This is the resulting garbage. Not that I could decipher the chinese
characters which should be here instead, but at least they would look
way nicer. But see below:

> This e-mail and its attachments contain confidential information from New H3C, which is
> intended only for the person or entity whose address is listed above. Any use of the
> information contained herein in any way (including, but not limited to, total or partial
> disclosure, reproduction, or dissemination) by persons other than the intended
> recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender
> by phone or email immediately and delete it!

Can you please remove this disclaimer completely (which avoids the
garbage issue as well) ?

It does not make any sense if you send mail to a public mailing list:

 1) If you send mail to a public list which is archived in public then
    the information can't be confidential and restricted to a particular
    audience. It can be accessed by everyone on this planet who has
    access to the internet.

 2) If you really send confidental information accidentally then there
    is no way to delete it. It's out there in the public and in archives
    and you can't call it back.

Thanks,

        tglx
    


  reply	other threads:[~2020-05-13 21:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08  2:02 Xianting Tian
2020-05-13 21:22 ` Thomas Gleixner [this message]
2020-05-14  1:46   ` 答复: " Tianxianting
2020-05-15  1:15   ` Tianxianting
2020-05-14 15:20 [PATCH] timers: Use " Xianting Tian
2020-05-19  8:36 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zcz1qf9.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tian.xianting@h3c.com \
    --subject='Re: [PATCH] timers: use set_current_state macro' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).